Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b91e25a7-ae33-4865-8f9f-a12764022f43 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot recompile all workflows |
All 178 workflows are already recompiled — Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot update the apm versions in constants.go |
…m_dependencies.go Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6f67c46c-88b1-47af-b28d-762a5de182a4 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the pinned microsoft/apm-action version to pick up a bugfix around token handling, and threads an explicit default action version constant through APM workflow generation so lockfiles and pins stay in sync.
Changes:
- Bumped
microsoft/apm-actionpin fromv1.4.0tov1.4.1(SHA update) in action pin/lock data. - Added
DefaultAPMActionVersion = "v1.4.1"and used it when generating the APM pack step viaGetActionPinWithData. - Recompiled the locked smoke workflow to reference the new pinned SHA.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/data/action_pins.json |
Updates the stored pin for microsoft/apm-action to v1.4.1 / new SHA. |
pkg/workflow/apm_dependencies.go |
Resolves microsoft/apm-action pin using GetActionPinWithData and the new default version constant. |
pkg/constants/constants.go |
Introduces DefaultAPMActionVersion to centrally track the default action version. |
.github/workflows/smoke-claude.lock.yml |
Updates the workflow lock to use the new microsoft/apm-action SHA/comment. |
.github/aw/actions-lock.json |
Updates the action lock entry for microsoft/apm-action to v1.4.1 / new SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| actionRef := GetActionPin("microsoft/apm-action") | ||
| actionRef, err := GetActionPinWithData("microsoft/apm-action", string(constants.DefaultAPMActionVersion), data) | ||
| if err != nil { |
There was a problem hiding this comment.
GetActionPinWithData can return an empty actionRef with err == nil when it can’t pin the requested version (e.g., strict mode with no exact match, or repo not present in pins). This code only falls back on err != nil, so you can end up emitting uses: (empty) which produces invalid workflow YAML. Handle actionRef == "" as a failure case too, and fall back to a safe reference (e.g., repo@DefaultAPMActionVersion or GetActionPin(...)) while still logging the warning.
| if err != nil { | |
| if err != nil || actionRef == "" { |
| "super-linter/super-linter@v8.5.0": { | ||
| "repo": "super-linter/super-linter", | ||
| "version": "v8.5.0", | ||
| "sha": "61abc07d755095a68f4987d1c2c3d1d64408f1f9" | ||
| }, | ||
| "microsoft/apm-action@v1.4.1": { | ||
| "repo": "microsoft/apm-action", | ||
| "version": "v1.4.1", | ||
| "sha": "a190b0b1a91031057144dc136acf9757a59c9e4d" | ||
| } |
There was a problem hiding this comment.
The entries object in this file is otherwise kept in lexicographic order by key (e.g., haskell-actions/... then oven-sh/...). The newly added microsoft/apm-action@v1.4.1 entry is appended after super-linter/..., which breaks the established ordering and makes future diffs noisier. Move this entry to its sorted position.
| "super-linter/super-linter@v8.5.0": { | ||
| "repo": "super-linter/super-linter", | ||
| "version": "v8.5.0", | ||
| "sha": "61abc07d755095a68f4987d1c2c3d1d64408f1f9" | ||
| }, | ||
| "microsoft/apm-action@v1.4.1": { | ||
| "repo": "microsoft/apm-action", | ||
| "version": "v1.4.1", | ||
| "sha": "a190b0b1a91031057144dc136acf9757a59c9e4d" | ||
| } |
There was a problem hiding this comment.
The entries object appears to be maintained in lexicographic order by key throughout the file, but the new microsoft/apm-action@v1.4.1 entry is appended after super-linter/.... Reinsert it at the appropriate sorted location to keep the lockfile deterministic and reduce diff noise.
|
❌ Tool validation failed! Agent Container Smoke Test detected missing tools: failed |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
|
💥 Smoke test 23614910060 results: 1 ✅ GitHub MCP | 2 ✅ GH CLI | 3 ✅ Serena (3 symbols) | 4 ✅ Make build | 5 ✅ Playwright Overall: PARTIAL (17 pass, 1 skipped)
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal! Reviewed the APM action bump from v1.4.0 to v1.4.1 with the new DefaultAPMActionVersion constant. The changes look clean and consistent with existing patterns.
💥 [THE END] — Illustrated by Smoke Claude
| }, | ||
| } | ||
|
|
||
| // DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action |
There was a problem hiding this comment.
The constant DefaultAPMActionVersion follows the same pattern as DefaultGitHubScriptVersion. Consider adding a brief comment linking to the upstream release notes or changelog so future reviewers can quickly verify what changed between versions.
|
Commit pushed:
|
Smoke Test: Codex 23614909967
|
microsoft/apm-action@v1.4.0had a bug where it shadowed a caller-providedGITHUB_TOKENwithGITHUB_APM_PAT(defaulting togithub.token), breaking cross-org private repo installs. v1.4.1 fixes this.Changes
microsoft/apm-actionv1.4.0→v1.4.1(cc84c04→a190b0b) in.github/aw/actions-lock.jsonand synced topkg/workflow/data/action_pins.jsonDefaultAPMActionVersion = "v1.4.1"added topkg/constants/constants.goto explicitly track themicrosoft/apm-actionGitHub Action versionapm_dependencies.goupdated to useGetActionPinWithDatawithDefaultAPMActionVersion(consistent with theDefaultGitHubScriptVersionpattern used elsewhere)smoke-claude.lock.ymlrecompiled — the only workflow using APM dependencies📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.
✨ PR Review Safe Output Test - Run 23614910060
Changeset
microsoft/apm-actiontov1.4.1and addedDefaultAPMActionVersion-based pin resolution for APM dependencies to fix token handling for cross-org private repository installs.