Skip to content

bump microsoft/apm-action to v1.4.1, add DefaultAPMActionVersion constant, rebuild wasm, recompile#23150

Merged
pelikhan merged 5 commits intomainfrom
copilot/update-apm-action-and-version
Mar 26, 2026
Merged

bump microsoft/apm-action to v1.4.1, add DefaultAPMActionVersion constant, rebuild wasm, recompile#23150
pelikhan merged 5 commits intomainfrom
copilot/update-apm-action-and-version

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

microsoft/apm-action@v1.4.0 had a bug where it shadowed a caller-provided GITHUB_TOKEN with GITHUB_APM_PAT (defaulting to github.token), breaking cross-org private repo installs. v1.4.1 fixes this.

Changes

  • microsoft/apm-action v1.4.0v1.4.1 (cc84c04a190b0b) in .github/aw/actions-lock.json and synced to pkg/workflow/data/action_pins.json
  • DefaultAPMActionVersion = "v1.4.1" added to pkg/constants/constants.go to explicitly track the microsoft/apm-action GitHub Action version
  • apm_dependencies.go updated to use GetActionPinWithData with DefaultAPMActionVersion (consistent with the DefaultGitHubScriptVersion pattern used elsewhere)
  • smoke-claude.lock.yml recompiled — the only workflow using APM dependencies
  • Wasm binary rebuilt against updated action pins

[!WARNING]


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.



✨ PR Review Safe Output Test - Run 23614910060

💥 [THE END] — Illustrated by Smoke Claude ·


Changeset

  • Type: patch
  • Description: Updated microsoft/apm-action to v1.4.1 and added DefaultAPMActionVersion-based pin resolution for APM dependencies to fix token handling for cross-org private repository installs.

Generated by Changeset Generator for issue #23150 ·

Copilot AI changed the title [WIP] Update apm-action and Microsoft/apm version, build wasm and recompile bump microsoft/apm-action to v1.4.1, rebuild wasm, recompile Mar 26, 2026
Copilot AI requested a review from pelikhan March 26, 2026 18:25
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot recompile all workflows

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot recompile all workflows

All 178 workflows are already recompiled — make recompile was run as part of the original commit and produces no further diffs. Only smoke-claude.lock.yml changed since it's the only workflow that references microsoft/apm-action.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0 --jq .object.sha (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot update the apm versions in constants.go

…m_dependencies.go

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6f67c46c-88b1-47af-b28d-762a5de182a4

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot update the apm versions in constants.go

Added DefaultAPMActionVersion = "v1.4.1" to pkg/constants/constants.go and updated apm_dependencies.go to use it via GetActionPinWithData (consistent with the DefaultGitHubScriptVersion pattern). Commit: d8ae8fd

Copilot AI changed the title bump microsoft/apm-action to v1.4.1, rebuild wasm, recompile bump microsoft/apm-action to v1.4.1, add DefaultAPMActionVersion constant, rebuild wasm, recompile Mar 26, 2026
@pelikhan pelikhan marked this pull request as ready for review March 26, 2026 19:48
Copilot AI review requested due to automatic review settings March 26, 2026 19:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned microsoft/apm-action version to pick up a bugfix around token handling, and threads an explicit default action version constant through APM workflow generation so lockfiles and pins stay in sync.

Changes:

  • Bumped microsoft/apm-action pin from v1.4.0 to v1.4.1 (SHA update) in action pin/lock data.
  • Added DefaultAPMActionVersion = "v1.4.1" and used it when generating the APM pack step via GetActionPinWithData.
  • Recompiled the locked smoke workflow to reference the new pinned SHA.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/workflow/data/action_pins.json Updates the stored pin for microsoft/apm-action to v1.4.1 / new SHA.
pkg/workflow/apm_dependencies.go Resolves microsoft/apm-action pin using GetActionPinWithData and the new default version constant.
pkg/constants/constants.go Introduces DefaultAPMActionVersion to centrally track the default action version.
.github/workflows/smoke-claude.lock.yml Updates the workflow lock to use the new microsoft/apm-action SHA/comment.
.github/aw/actions-lock.json Updates the action lock entry for microsoft/apm-action to v1.4.1 / new SHA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


actionRef := GetActionPin("microsoft/apm-action")
actionRef, err := GetActionPinWithData("microsoft/apm-action", string(constants.DefaultAPMActionVersion), data)
if err != nil {
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetActionPinWithData can return an empty actionRef with err == nil when it can’t pin the requested version (e.g., strict mode with no exact match, or repo not present in pins). This code only falls back on err != nil, so you can end up emitting uses: (empty) which produces invalid workflow YAML. Handle actionRef == "" as a failure case too, and fall back to a safe reference (e.g., repo@DefaultAPMActionVersion or GetActionPin(...)) while still logging the warning.

Suggested change
if err != nil {
if err != nil || actionRef == "" {

Copilot uses AI. Check for mistakes.
Comment on lines 176 to 185
"super-linter/super-linter@v8.5.0": {
"repo": "super-linter/super-linter",
"version": "v8.5.0",
"sha": "61abc07d755095a68f4987d1c2c3d1d64408f1f9"
},
"microsoft/apm-action@v1.4.1": {
"repo": "microsoft/apm-action",
"version": "v1.4.1",
"sha": "a190b0b1a91031057144dc136acf9757a59c9e4d"
}
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entries object in this file is otherwise kept in lexicographic order by key (e.g., haskell-actions/... then oven-sh/...). The newly added microsoft/apm-action@v1.4.1 entry is appended after super-linter/..., which breaks the established ordering and makes future diffs noisier. Move this entry to its sorted position.

Copilot uses AI. Check for mistakes.
Comment on lines 176 to 185
"super-linter/super-linter@v8.5.0": {
"repo": "super-linter/super-linter",
"version": "v8.5.0",
"sha": "61abc07d755095a68f4987d1c2c3d1d64408f1f9"
},
"microsoft/apm-action@v1.4.1": {
"repo": "microsoft/apm-action",
"version": "v1.4.1",
"sha": "a190b0b1a91031057144dc136acf9757a59c9e4d"
}
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entries object appears to be maintained in lexicographic order by key throughout the file, but the new microsoft/apm-action@v1.4.1 entry is appended after super-linter/.... Reinsert it at the appropriate sorted location to keep the lockfile deterministic and reduce diff noise.

Copilot uses AI. Check for mistakes.
@pelikhan pelikhan added the smoke label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

❌ Tool validation failed! Agent Container Smoke Test detected missing tools: failed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Copy Markdown
Contributor

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions github-actions bot removed the smoke label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident...

@github-actions
Copy link
Copy Markdown
Contributor

💥 Smoke test 23614910060 results:

1 ✅ GitHub MCP | 2 ✅ GH CLI | 3 ✅ Serena (3 symbols) | 4 ✅ Make build | 5 ✅ Playwright
6 ✅ Tavily search | 7 ✅ File write | 8 ✅ Bash | 9 ✅ Discussion | 10 ✅ AW MCP | 11 ✅ Slack
12 ✅ Update PR | 13 ✅ Review comments | 14 ✅ Submit review | 15 ✅ Resolve thread
16 ✅ Add reviewer | 17 ✅ Push branch | 18 ⚠️ Close PR (skipped — no safe PR)

Overall: PARTIAL (17 pass, 1 skipped)

💥 [THE END] — Illustrated by Smoke Claude ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Automated smoke test review - all systems nominal! Reviewed the APM action bump from v1.4.0 to v1.4.1 with the new DefaultAPMActionVersion constant. The changes look clean and consistent with existing patterns.

💥 [THE END] — Illustrated by Smoke Claude

},
}

// DefaultAPMActionVersion is the default version of the microsoft/apm-action GitHub Action
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constant DefaultAPMActionVersion follows the same pattern as DefaultGitHubScriptVersion. Consider adding a brief comment linking to the upstream release notes or changelog so future reviewers can quickly verify what changed between versions.

@github-actions
Copy link
Copy Markdown
Contributor

Commit pushed: ab0b8eb

Generated by Changeset Generator

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Codex 23614909967

🔮 The oracle has spoken through Smoke Codex ·

@pelikhan pelikhan merged commit a68967c into main Mar 26, 2026
@pelikhan pelikhan deleted the copilot/update-apm-action-and-version branch March 26, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants