-
Notifications
You must be signed in to change notification settings - Fork 295
[docs] docs: reduce bloat in IssueOps guide #2329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -39,7 +39,7 @@ This workflow creates an intelligent issue triage system that automatically resp | |||||
|
|
||||||
| ## Safe Output Architecture | ||||||
|
|
||||||
| IssueOps workflows use the `add-comment` safe output to ensure secure comment creation: | ||||||
| IssueOps workflows use the `add-comment` safe output to ensure secure comment creation with minimal permissions. The main job runs with `contents: read` while comment creation happens in a separate job with `issues: write` permissions, automatically sanitizing AI content and preventing spam: | ||||||
|
|
||||||
| ```yaml | ||||||
| safe-outputs: | ||||||
|
|
@@ -48,28 +48,16 @@ safe-outputs: | |||||
| target: "triggering" # Default: comment on the triggering issue/PR | ||||||
| ``` | ||||||
|
|
||||||
| **Security Benefits**: | ||||||
| - Main job runs with minimal `contents: read` permissions | ||||||
| - Comment creation happens in a separate job with appropriate `issues: write` permissions | ||||||
| - Automatic sanitization of AI-generated content | ||||||
| - Built-in limits prevent comment spam | ||||||
|
|
||||||
| ## Accessing Issue Context | ||||||
|
|
||||||
| IssueOps workflows have access to sanitized issue content through the `needs.activation.outputs.text` variable: | ||||||
| IssueOps workflows access sanitized issue content through the `needs.activation.outputs.text` variable, which combines the issue title and description while removing security risks (@mention neutralization, URI filtering, injection protection): | ||||||
|
||||||
| IssueOps workflows access sanitized issue content through the `needs.activation.outputs.text` variable, which combines the issue title and description while removing security risks (@mention neutralization, URI filtering, injection protection): | |
| IssueOps workflows access sanitized issue content through the `needs.activation.outputs.text` variable, which combines the issue title and description while removing security risks (neutralizes @mentions, filters URIs, and protects against injection): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This sentence has become a run-on with multiple clauses. Consider breaking it into two sentences for better readability: 'IssueOps workflows use the
add-commentsafe output to ensure secure comment creation with minimal permissions. The main job runs withcontents: readwhile comment creation happens in a separate job withissues: writepermissions, automatically sanitizing AI content and preventing spam.'