fix: update DefaultFirewallVersion and AWFExcludeEnvMinVersion to v0.25.3#23398
Closed
fix: update DefaultFirewallVersion and AWFExcludeEnvMinVersion to v0.25.3#23398
Conversation
…25.3 The --exclude-env flag was introduced in gh-aw-firewall v0.25.3, not v0.26.0. The CI version availability check was failing because v0.26.0 does not exist as a GitHub release. Updates constants, comments, tests, and golden files. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/73b3aa44-b1c7-466e-acca-38d8035123ae Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
March 29, 2026 00:02
View session
Collaborator
|
@copilot Recompute |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/185199d4-4158-4ebe-9354-8e05434236bc Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Done in 0a54d1b — recompiled all 178 workflow lock files, updating Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI version availability check was failing because
DefaultFirewallVersionandAWFExcludeEnvMinVersionwere both set tov0.26.0, which does not exist as agh-aw-firewallrelease. The--exclude-envflag was actually shipped inv0.25.3.Changes
pkg/constants/constants.go:DefaultFirewallVersionandAWFExcludeEnvMinVersionv0.26.0→v0.25.3pkg/workflow/awf_helpers.go: Updated 3 comments that referencedv0.26.0as the minimumpkg/workflow/awf_helpers_test.go: Updated comment; addedv0.25.3(positive boundary) andv0.25.2(negative boundary) test cases toTestAWFSupportsExcludeEnvbasic-copilot,with-imports,smoke-copilot):0.26.0→0.25.3in--image-tag, install script args, andGH_AW_INFO_AWF_VERSIONfirewall_image_tag_test.goandgh_cli_mount_test.goupdated to referencev0.25.3