Skip to content

fix: update DefaultFirewallVersion and AWFExcludeEnvMinVersion to v0.25.3#23398

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/ensure-firewall-test-constants-match
Closed

fix: update DefaultFirewallVersion and AWFExcludeEnvMinVersion to v0.25.3#23398
Copilot wants to merge 2 commits intomainfrom
copilot/ensure-firewall-test-constants-match

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 29, 2026

The CI version availability check was failing because DefaultFirewallVersion and AWFExcludeEnvMinVersion were both set to v0.26.0, which does not exist as a gh-aw-firewall release. The --exclude-env flag was actually shipped in v0.25.3.

Changes

  • pkg/constants/constants.go: DefaultFirewallVersion and AWFExcludeEnvMinVersion v0.26.0v0.25.3
  • pkg/workflow/awf_helpers.go: Updated 3 comments that referenced v0.26.0 as the minimum
  • pkg/workflow/awf_helpers_test.go: Updated comment; added v0.25.3 (positive boundary) and v0.25.2 (negative boundary) test cases to TestAWFSupportsExcludeEnv
  • Golden files (basic-copilot, with-imports, smoke-copilot): 0.26.00.25.3 in --image-tag, install script args, and GH_AW_INFO_AWF_VERSION
  • Stale comments in firewall_image_tag_test.go and gh_cli_mount_test.go updated to reference v0.25.3

…25.3

The --exclude-env flag was introduced in gh-aw-firewall v0.25.3, not v0.26.0.
The CI version availability check was failing because v0.26.0 does not exist
as a GitHub release. Updates constants, comments, tests, and golden files.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/73b3aa44-b1c7-466e-acca-38d8035123ae

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Copy Markdown
Collaborator

@copilot Recompute

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 29, 2026

@copilot Recompute

Done in 0a54d1b — recompiled all 178 workflow lock files, updating v0.26.0v0.25.3 throughout (AWF install scripts, Docker image tags, and GH_AW_INFO_AWF_VERSION env vars).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .visibility (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0 --jq .object.sha (http block)
  • https://api.github.com/repos/githubnext/agentics/git/ref/tags/
    • Triggering command: /usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/# --jq .object.sha (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from pelikhan March 29, 2026 00:19
@pelikhan pelikhan closed this Mar 29, 2026
@github-actions github-actions bot deleted the copilot/ensure-firewall-test-constants-match branch April 5, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants