Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive performance tracking and caching to the workflow compilation process to improve performance and provide better visibility into compilation times.
Key changes:
- Introduced
TimingTrackerto measure and report compilation step durations - Added caching for repository feature checks to reduce redundant API calls
- Enhanced verbose mode with timing summaries and performance metrics
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pkg/workflow/timing.go | New file implementing TimingTracker for tracking compilation step durations with support for nested sub-steps |
| pkg/workflow/validation.go | Added caching for repository features and current repository lookups, integrated timing tracking into validation steps |
| pkg/workflow/compiler_yaml.go | Integrated timing tracking into YAML generation sub-steps |
| pkg/workflow/compiler.go | Added timingTracker field to Compiler, instrumented all compilation steps with timing, refactored error handling in file output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsyme
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary