Remove observability.job-summary opt-in, render job summary when OTLP is enabled

actions/setup/js/generate_observability_summary.cjs

@@ -114,12 +114,6 @@ function buildObservabilitySummary(data) {
 }
 
 async function main(core) {
-  const mode = process.env.GH_AW_OBSERVABILITY_JOB_SUMMARY || "";
-  if (mode !== "on") {
-    core.info(`Skipping observability summary: mode=${mode || "unset"}`);
-    return;
-  }
-
   const data = collectObservabilityData();
   const markdown = buildObservabilitySummary(data);
   await core.summary.addRaw(markdown).write();

actions/setup/js/generate_observability_summary.test.cjs

@@ -17,12 +17,10 @@ describe("generate_observability_summary.cjs", () => {
   beforeEach(async () => {
     vi.clearAllMocks();
     fs.mkdirSync("/tmp/gh-aw/mcp-logs", { recursive: true });
-    process.env.GH_AW_OBSERVABILITY_JOB_SUMMARY = "on";
     module = await import("./generate_observability_summary.cjs");
   });
 
   afterEach(() => {
-    delete process.env.GH_AW_OBSERVABILITY_JOB_SUMMARY;
     for (const path of ["/tmp/gh-aw/aw_info.json", "/tmp/gh-aw/agent_output.json", "/tmp/gh-aw/mcp-logs/gateway.jsonl", "/tmp/gh-aw/mcp-logs/rpc-messages.jsonl"]) {
       if (fs.existsSync(path)) {
         fs.unlinkSync(path);
@@ -87,13 +85,10 @@ describe("generate_observability_summary.cjs", () => {
     expect(summary).toContain("- **trace id**: 12345678901-1");
   });
 
-  it("skips summary generation when opt-in mode is disabled", async () => {
-    process.env.GH_AW_OBSERVABILITY_JOB_SUMMARY = "off";
-
+  it("always generates summary regardless of env vars", async () => {
     await module.main(mockCore);
 
-    expect(mockCore.summary.addRaw).not.toHaveBeenCalled();
-    expect(mockCore.summary.write).not.toHaveBeenCalled();
-    expect(mockCore.info).toHaveBeenCalledWith("Skipping observability summary: mode=off");
+    expect(mockCore.summary.addRaw).toHaveBeenCalledTimes(1);
+    expect(mockCore.summary.write).toHaveBeenCalledTimes(1);
   });
 });

docs/public/editor/autocomplete-data.json

@@ -1646,14 +1646,7 @@
     "observability": {
       "type": "object",
       "desc": "Optional observability output settings for workflow runs.",
-      "children": {
-        "job-summary": {
-          "type": "string",
-          "desc": "If set to 'on', append a compact observability section to the GitHub Actions job summary.",
-          "enum": ["on", "off"],
-          "leaf": true
-        }
-      }
+      "children": {}
     },
     "bots": {
       "type": "array",

docs/src/content/docs/reference/frontmatter-full.md

@@ -5905,11 +5905,7 @@ secret-masking:
 
 # Optional observability output settings for workflow runs.
 # (optional)
-observability:
-  # If set to 'on', append a compact observability section to the GitHub Actions job
-  # summary. Defaults to off when omitted.
-  # (optional)
-  job-summary: "on"
+observability: {}
 
 # Allow list of bot identifiers that can trigger the workflow even if they don't
 # meet the required role permissions. When the actor is in this list, the bot must

pkg/parser/import_field_extractor.go

@@ -30,6 +30,7 @@ type importAccumulator struct {
 	secretMaskingBuilder     strings.Builder
 	postStepsBuilder         strings.Builder
 	jobsBuilder              strings.Builder // Jobs from imported YAML workflows
+	observabilityBuilder     strings.Builder // observability config (first-wins for OTLP endpoint)
 	engines                  []string
 	safeOutputs              []string
 	mcpScripts               []string
@@ -350,6 +351,17 @@ func (acc *importAccumulator) extractAllImportFields(content []byte, item import
 		}
 	}
 
+	// Extract observability from imported file (first-wins: only set if not yet populated).
+	// This ensures an imported workflow's OTLP config is visible to injectOTLPConfig even
+	// when the main workflow's frontmatter does not contain an observability section.
+	if acc.observabilityBuilder.Len() == 0 {
+		obsContent, obsErr := extractFieldJSONFromMap(fm, "observability", "{}")
+		if obsErr == nil && obsContent != "" && obsContent != "{}" {
+			acc.observabilityBuilder.WriteString(obsContent)
+			log.Printf("Extracted observability from import: %s", item.fullPath)
+		}
+	}
+
 	return nil
 }
 
@@ -381,6 +393,7 @@ func (acc *importAccumulator) toImportsResult(topologicalOrder []string) *Import
 		MergedCaches:                acc.caches,
 		MergedJobs:                  acc.jobsBuilder.String(),
 		MergedFeatures:              acc.features,
+		MergedObservability:         acc.observabilityBuilder.String(),
 		ImportedFiles:               topologicalOrder,
 		AgentFile:                   acc.agentFile,
 		AgentImportSpec:             acc.agentImportSpec,

pkg/parser/import_processor.go

@@ -39,6 +39,7 @@ type ImportsResult struct {
 	MergedCaches                []string         // Merged cache configurations from all imports (appended in order)
 	MergedJobs                  string           // Merged jobs from imported YAML workflows (JSON format)
 	MergedFeatures              []map[string]any // Merged features configuration from all imports (parsed YAML structures)
+	MergedObservability         string           // Observability config (JSON) from first import that defines it (first-wins)
 	ImportedFiles               []string         // List of imported file paths (for manifest)
 	AgentFile                   string           // Path to custom agent file (if imported)
 	AgentImportSpec             string           // Original import specification for agent file (e.g., "owner/repo/path@ref")

pkg/parser/schema_test.go

@@ -194,25 +194,3 @@ func TestGetSafeOutputTypeKeys(t *testing.T) {
 		}
 	}
 }
-
-func TestValidateMainWorkflowFrontmatterWithSchema_AllowsObservabilityJobSummary(t *testing.T) {
-	frontmatter := map[string]any{
-		"on": "push",
-		"observability": map[string]any{
-			"job-summary": "on",
-		},
-	}
-
-	tempFile := "/tmp/gh-aw/test_observability_frontmatter.md"
-	if err := os.MkdirAll("/tmp/gh-aw", 0755); err != nil {
-		t.Fatalf("Failed to create temp directory: %v", err)
-	}
-	if err := os.WriteFile(tempFile, []byte("---\non: push\nobservability:\n  job-summary: on\n---\n"), 0644); err != nil {
-		t.Fatalf("Failed to create temp file: %v", err)
-	}
-	defer os.Remove(tempFile)
-
-	if err := ValidateMainWorkflowFrontmatterWithSchemaAndLocation(frontmatter, tempFile); err != nil {
-		t.Fatalf("Expected observability config to validate, got: %v", err)
-	}
-}

pkg/parser/schemas/main_workflow_schema.json

@@ -8324,11 +8324,6 @@
       "type": "object",
       "description": "Optional observability output settings for workflow runs.",
       "properties": {
-        "job-summary": {
-          "type": "string",
-          "enum": ["on", "off"],
-          "description": "If set to 'on', append a compact observability section to the GitHub Actions job summary. Defaults to off when omitted."
-        },
         "otlp": {
           "type": "object",
           "description": "OTLP (OpenTelemetry Protocol) trace export configuration.",

pkg/workflow/compiler_orchestrator_workflow.go

@@ -109,6 +109,18 @@ func (c *Compiler) ParseWorkflowFile(markdownPath string) (*WorkflowData, error)
 	// Extract YAML configuration sections from frontmatter
 	c.extractYAMLSections(result.Frontmatter, workflowData)
 
+	// Merge observability config from imports into RawFrontmatter so that injectOTLPConfig
+	// can see an OTLP endpoint defined in an imported workflow (first-wins from imports).
+	if obs := engineSetup.importsResult.MergedObservability; obs != "" {
+		if _, hasObs := workflowData.RawFrontmatter["observability"]; !hasObs {
+			var obsMap map[string]any
+			if err := json.Unmarshal([]byte(obs), &obsMap); err == nil {
+				workflowData.RawFrontmatter["observability"] = obsMap
+				orchestratorWorkflowLog.Printf("Merged observability config from imports into RawFrontmatter")
+			}
+		}
+	}
+
 	// Inject OTLP configuration: add endpoint domain to firewall allowlist and
 	// set OTEL env vars in the workflow env block (no-op when not configured).
 	c.injectOTLPConfig(workflowData)

pkg/workflow/compiler_yaml_ai_execution.go

@@ -7,31 +7,6 @@ import (
 	"github.com/github/gh-aw/pkg/constants"
 )
 
-func getObservabilityJobSummaryMode(data *WorkflowData) string {
-	if data == nil {
-		return ""
-	}
-
-	mode := ""
-	if data.ParsedFrontmatter != nil && data.ParsedFrontmatter.Observability != nil {
-		mode = data.ParsedFrontmatter.Observability.JobSummary
-	}
-
-	if mode == "" && data.RawFrontmatter != nil {
-		if rawObservability, ok := data.RawFrontmatter["observability"].(map[string]any); ok {
-			if rawMode, ok := rawObservability["job-summary"].(string); ok {
-				mode = rawMode
-			}
-		}
-	}
-
-	if mode == "off" {
-		return ""
-	}
-
-	return mode
-}
-
 // generateEngineExecutionSteps generates the GitHub Actions steps for executing the AI engine
 func (c *Compiler) generateEngineExecutionSteps(yaml *strings.Builder, data *WorkflowData, engine CodingAgentEngine, logFile string) {
 
@@ -119,21 +94,19 @@ func (c *Compiler) generateMCPGatewayLogParsing(yaml *strings.Builder) {
 	yaml.WriteString("            await main();\n")
 }
 
-// generateObservabilitySummary generates an opt-in step that synthesizes a compact
+// generateObservabilitySummary generates a step that synthesizes a compact
 // observability section for the GitHub Actions step summary from existing runtime files.
+// The step is only emitted when OTLP is configured in the workflow.
 func (c *Compiler) generateObservabilitySummary(yaml *strings.Builder, data *WorkflowData) {
-	mode := getObservabilityJobSummaryMode(data)
-	if mode == "" {
+	if !isOTLPEnabled(data) {
 		return
 	}
 
-	compilerYamlLog.Printf("Generating observability step summary: mode=%s", mode)
+	compilerYamlLog.Print("Generating observability step summary")
 
 	yaml.WriteString("      - name: Generate observability summary\n")
 	yaml.WriteString("        if: always()\n")
 	fmt.Fprintf(yaml, "        uses: %s\n", GetActionPin("actions/github-script"))
-	yaml.WriteString("        env:\n")
-	fmt.Fprintf(yaml, "          GH_AW_OBSERVABILITY_JOB_SUMMARY: %q\n", mode)
 	yaml.WriteString("        with:\n")
 	yaml.WriteString("          script: |\n")
 	yaml.WriteString("            const { setupGlobals } = require('" + SetupActionDestination + "/setup_globals.cjs');\n")
@@ -142,6 +115,17 @@ func (c *Compiler) generateObservabilitySummary(yaml *strings.Builder, data *Wor
 	yaml.WriteString("            await main(core);\n")
 }
 
+// isOTLPEnabled returns true when OTLP has been configured in the workflow (including
+// imported frontmatter). It checks whether injectOTLPConfig has already written the
+// OTEL_EXPORTER_OTLP_ENDPOINT env var into workflowData.Env, which is the authoritative
+// result of OTLP detection after all frontmatter (main + imports) has been processed.
+func isOTLPEnabled(data *WorkflowData) bool {
+	if data == nil {
+		return false
+	}
+	return strings.Contains(data.Env, "OTEL_EXPORTER_OTLP_ENDPOINT")
+}
+
 // generateStopMCPGateway generates a step that stops the MCP gateway process using its PID from step output
 // It passes the gateway port and API key to enable graceful shutdown via /close endpoint
 func (c *Compiler) generateStopMCPGateway(yaml *strings.Builder, data *WorkflowData) {

pkg/workflow/compiler_yaml_main_job.go

@@ -443,7 +443,7 @@ func (c *Compiler) generateMainJobSteps(yaml *strings.Builder, data *WorkflowDat
 		artifactPaths = append(artifactPaths, "/tmp/gh-aw/"+constants.TokenUsageFilename)
 	}
 
-	// Optionally synthesize a compact observability section from runtime artifacts.
+	// Synthesize a compact observability section from runtime artifacts when OTLP is enabled.
 	c.generateObservabilitySummary(yaml, data)
 
 	// Collect agent stdio logs path for unified upload

pkg/workflow/frontmatter_types.go

@@ -134,8 +134,7 @@ type OTLPConfig struct {
 
 // ObservabilityConfig represents workflow observability options.
 type ObservabilityConfig struct {
-	JobSummary string      `json:"job-summary,omitempty"`
-	OTLP       *OTLPConfig `json:"otlp,omitempty"`
+	OTLP *OTLPConfig `json:"otlp,omitempty"`
 }
 
 // FrontmatterConfig represents the structured configuration from workflow frontmatter

pkg/workflow/frontmatter_types_test.go

@@ -248,7 +248,9 @@ func TestParseFrontmatterConfig(t *testing.T) {
 	t.Run("handles observability configuration", func(t *testing.T) {
 		frontmatter := map[string]any{
 			"observability": map[string]any{
-				"job-summary": "on",
+				"otlp": map[string]any{
+					"endpoint": "https://traces.example.com",
+				},
 			},
 		}
 
@@ -261,8 +263,8 @@ func TestParseFrontmatterConfig(t *testing.T) {
 			t.Fatal("Observability should not be nil")
 		}
 
-		if config.Observability.JobSummary != "on" {
-			t.Errorf("JobSummary = %q, want %q", config.Observability.JobSummary, "on")
+		if config.Observability.OTLP == nil {
+			t.Fatal("OTLP should not be nil")
 		}
 	})