Skip to content

fix(lint): use require.NoError for error assertion in gitutil_test.go #24817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Apr 6, 2026
Merged

fix(lint): use require.NoError for error assertion in gitutil_test.go #24817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/gitutil/gitutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestIsRateLimitError(t *testing.T) {
Expand Down Expand Up @@ -245,7 +246,7 @@ func TestExtractBaseRepo(t *testing.T) {
func TestFindGitRoot(t *testing.T) {
t.Run("returns non-empty path when inside a git repository", func(t *testing.T) {
gitRoot, err := FindGitRoot()
assert.NoError(t, err, "FindGitRoot should succeed when running inside a git repository")
require.NoError(t, err, "FindGitRoot should succeed when running inside a git repository")
assert.NotEmpty(t, gitRoot, "FindGitRoot should return a non-empty path")
})
}
Loading