feat: add architecture-guardian agentic workflow by Copilot · Pull Request #25334 · github/gh-aw

Copilot · 2026-04-08T15:43:44Z

Adds a new architecture-guardian workflow addressing the "spaghetti codebase" problem — AI-assisted development accumulates structural debt without enforcement checkpoints.

What it does

Triggers daily on weekdays (~2 PM UTC) via schedule, with workflow_dispatch as a fallback
Analyzes Go and JavaScript source files changed in the last 24 hours for:
- Files exceeding 500 lines (WARNING) / 1000 lines (BLOCKER)
- Functions exceeding 80 lines (WARNING) via grep/awk on Go func declarations and grep on JS function declarations
- 10 public exports per file (INFO) — uppercase identifiers for Go, module.exports/export for JavaScript
- Circular import cycles (BLOCKER) via go list ./... / go build ./... for Go and grep-based require() analysis for JavaScript
Creates a structured GitHub issue grouped by severity (BLOCKER / WARNING / INFO) with AI-generated refactoring suggestions (what, why, concrete fix) and an action checklist
Skips automatically if no Go/JavaScript files changed in the last 24 hours, or if an open issue already exists (skip-if-match)

Configuration

Thresholds are configurable via .architecture.yml at the repo root; all values have sensible defaults if the file is absent.

Files

.github/workflows/architecture-guardian.md — workflow source
.github/workflows/architecture-guardian.lock.yml — compiled output

Adds .github/workflows/architecture-guardian.md and the compiled .lock.yml to enforce code structure discipline on every PR and push to main. The workflow: - Detects files exceeding 500/1000 lines (WARNING/BLOCKER) - Detects functions exceeding 80 lines (WARNING) - Detects high public export count >10 (INFO) - Detects circular imports/dependency cycles (BLOCKER) - Posts structured PR review grouped by severity - Fails PR check on BLOCKER violations - Thresholds configurable via .architecture.yml Closes #25378" Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7af87394-21f4-4209-ba3d-375346b57b4a Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-04-08T16:07:04Z

Change trigger to run daily on weekdays and operate on the changes since the last run

pelikhan · 2026-04-08T16:07:24Z

@copilot Change trigger to run daily on weekdays and operate on the changes since the last run

… lookback - Trigger changed from pull_request+push to daily schedule on weekdays (~2 PM UTC) - Workflow now analyzes commits from the last 24 hours instead of PR diffs - safe-outputs changed from submit-pull-request-review to create-issue - Added skip-if-match to avoid creating duplicate issues - Added tracker-id for workflow identity tracking - Updated prompt: Step 2 now uses git log --since="24 hours ago" - Updated prompt: Step 6 now creates a GitHub issue with action checklist - Removed PR-specific language (REQUEST_CHANGES review, base SHA diff) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ea35747c-7522-4c93-84e4-d44eadc4bb90 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-04-08T16:15:13Z

@copilot Change trigger to run daily on weekdays and operate on the changes since the last run

Done in 875afbd. Changed the trigger from pull_request + push to main to schedule: "daily around 14:00 on weekdays" with workflow_dispatch as a fallback.

The workflow now:

Uses git log --since="24 hours ago" to find changed Python/Rust files
Skips automatically if no files changed (noop)
Creates a GitHub issue (instead of a PR review) with violations grouped by BLOCKER/WARNING/INFO and an action checklist
Avoids duplicate issues via skip-if-match: 'is:issue is:open in:title "[architecture-guardian]"'

pelikhan · 2026-04-08T16:42:10Z

@copilot this codebase is Go and JavaScript

- File filter changed from .py/.rs to .go/.js/.cjs/.mjs - Check 2 (function size) rewritten for Go: uses grep + awk on func declarations - Check 3 (function size) rewritten for JavaScript: uses grep on function declarations - Check 4 (public exports) rewritten for Go: greps exported identifiers (uppercase), and module.exports / export for JS files - Check 5 (import cycles) rewritten for Go: uses go list/go build to detect cycles, plus grep-based JS circular require detection - Removed python3 from bash tool allowlist (no longer needed) - Updated all examples and descriptions to reference .go files and Go/JS idioms Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b6d21b68-d7cd-444e-aa9d-372c363a73d5 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-04-08T16:50:19Z

@copilot this codebase is Go and JavaScript

Fixed in 97cf245. The workflow now analyzes Go and JavaScript files instead of Python and Rust:

File filter: .go, .js, .cjs, .mjs
Function size: grep/awk on func declarations (Go) and function declarations (JS)
Export count: uppercase identifiers (Go), module.exports/export (JS)
Import cycles: go list ./... / go build ./... for Go; grep-based require() analysis for JS
Removed python3 from the bash tool allowlist

Copilot

Pull request overview

Adds a new scheduled “Architecture Guardian” agentic workflow intended to scan Go/JS changes from the last 24 hours for structural/code-architecture violations and file an issue when thresholds are exceeded.

Changes:

Introduces a new agent prompt workflow definition for architecture checks (file size, function size, export count, import cycles).
Adds the compiled .lock.yml workflow output generated from the .md source.

Show a summary per file

File	Description
`.github/workflows/architecture-guardian.md`	Defines the agent’s prompt, triggers, tool allowlist, and safe-outputs behavior for architecture scans.
`.github/workflows/architecture-guardian.lock.yml`	Compiled GitHub Actions workflow produced from the `.md` definition.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 2

Copilot · 2026-04-08T17:10:01Z

.github/workflows/architecture-guardian.md

+tools:
+  github:
+    toolsets: [repos]
+  bash:
+    - "git log:*"
+    - "git diff:*"
+    - "git show:*"
+    - "find:*"


The prompt relies on running go list ./... / go build ./... to detect import cycles, but the bash tool allowlist here doesn’t permit any go commands. As a result the agent won’t be able to execute the cycle check as written. Add explicit allowlist entries for the needed Go commands (e.g., go list:* and go build:*, or a tighter subset) similar to .github/workflows/sergo.md which allowlists go list -m all.

Copilot · 2026-04-08T17:10:01Z

.github/workflows/architecture-guardian.md

+safe-outputs:
+  create-issue:
+    expires: 2d
+    title-prefix: "[architecture-guardian] "
+    labels: [architecture, automated-analysis, cookie]
+    assignees: copilot
+    max: 1
+  noop:
+  messages:


safe-outputs.noop is declared without report-as-issue: false, which means the compiled workflow defaults to reporting no-op messages as issues ("report-as-issue":"true" in the lock file). That contradicts the stated behavior of “skip automatically” when there are no relevant changes / no violations, and will likely create daily noise issues. Set safe-outputs.noop.report-as-issue: false (as done in .github/workflows/agentic-observability-kit.md:28-29) if the intent is to truly skip without opening an issue.

Add entries to the examples documentation for the five new workflows merged on 2026-04-08: - Test Quality Sentinel (#25353): PR-triggered test quality analysis - Approach Validator (#25354): label-triggered multi-agent approach review - Design Decision Gate (#25323): ADR enforcement before implementation merges - Refactoring Cadence (#25352): daily code health tracking with auto-issue - Architecture Guardian (#25334): daily code structure violation detection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Initial plan

75f7122

Copilot AI assigned Copilot and pelikhan Apr 8, 2026

Copilot started work on behalf of pelikhan April 8, 2026 15:45 View session

Copilot AI linked an issue Apr 8, 2026 that may be closed by this pull request

[plan] Create "architecture-guardian" agentic workflow #25317

Closed

7 tasks

Copilot AI changed the title ~~[WIP] Create architecture-guardian agentic workflow~~ feat: add architecture-guardian agentic workflow Apr 8, 2026

Copilot finished work on behalf of pelikhan April 8, 2026 16:05

Copilot AI requested a review from pelikhan April 8, 2026 16:05

Copilot started work on behalf of pelikhan April 8, 2026 16:07 View session

Copilot finished work on behalf of pelikhan April 8, 2026 16:16

github-actions bot mentioned this pull request Apr 8, 2026

Smoke Test: Claude - 24146254696 #25340

Closed

Copilot started work on behalf of pelikhan April 8, 2026 16:42 View session

Copilot finished work on behalf of pelikhan April 8, 2026 16:51

pelikhan marked this pull request as ready for review April 8, 2026 17:05

Copilot AI review requested due to automatic review settings April 8, 2026 17:05

pelikhan merged commit 559b2b3 into main Apr 8, 2026
52 checks passed

pelikhan deleted the copilot/create-architecture-guardian-workflow branch April 8, 2026 17:05

Copilot started reviewing on behalf of pelikhan April 8, 2026 17:06 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

github-actions bot mentioned this pull request Apr 8, 2026

Smoke Test: Claude - 24148090336 #25348

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add architecture-guardian agentic workflow#25334

feat: add architecture-guardian agentic workflow#25334
pelikhan merged 4 commits intomainfrom
copilot/create-architecture-guardian-workflow

Copilot AI commented Apr 8, 2026 •

edited

Loading

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

Copilot AI commented Apr 8, 2026

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

Copilot AI commented Apr 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What it does

Configuration

Files

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

Copilot AI commented Apr 8, 2026

Uh oh!

pelikhan commented Apr 8, 2026

Uh oh!

Copilot AI commented Apr 8, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 8, 2026 •

edited

Loading