Skip to content

Rename codemod_plugins.go functions to include ToDependencies suffix #25789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 11, 2026
+6 −6
Merged

Rename codemod_plugins.go functions to include ToDependencies suffix #25789

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3207002
Initial plan
Copilot Apr 11, 2026
6bbccf9
rename rewritePluginsBlock and rewriteObjectFormatPlugins to include …
Copilot Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pkg/cli/codemod_plugins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func migratePluginsToDependencies(lines []string) ([]string, bool) {

// Collect the original block lines and rewrite them.
block := lines[pluginsIdx:blockEnd]
rewritten, changed := rewritePluginsBlock(block)
rewritten, changed := rewritePluginsBlockToDependencies(block)
if !changed {
return lines, false
}
Expand All @@ -92,13 +92,13 @@ func migratePluginsToDependencies(lines []string) ([]string, bool) {
return result, true
}

// rewritePluginsBlock transforms the lines of a plugins block into a
// rewritePluginsBlockToDependencies transforms the lines of a plugins block into a
// dependencies block, handling both array format and object format.
//
// Object format detection: if the block contains a `repos:` sub-key the input
// is in object format. The `repos:` items become `packages:` children under
// `dependencies:`; the `github-token:` key is preserved as-is.
func rewritePluginsBlock(block []string) ([]string, bool) {
func rewritePluginsBlockToDependencies(block []string) ([]string, bool) {
if len(block) == 0 {
return block, false
}
Expand All @@ -119,7 +119,7 @@ func rewritePluginsBlock(block []string) ([]string, bool) {
}

if isObjectFormat {
return rewriteObjectFormatPlugins(block, indent)
return rewriteObjectFormatPluginsToDependencies(block, indent)
}

// Array format – just rename the key and keep the body.
Expand All @@ -132,7 +132,7 @@ func rewritePluginsBlock(block []string) ([]string, bool) {
return result, true
}

// rewriteObjectFormatPlugins handles the object format:
// rewriteObjectFormatPluginsToDependencies handles the object format:
//
// plugins:
// repos:
Expand All @@ -141,7 +141,7 @@ func rewritePluginsBlock(block []string) ([]string, bool) {
//
// It produces a `dependencies:` object block with `packages:` (renamed from `repos:`)
// and preserves the `github-token:` key so APM can authenticate with the same token.
func rewriteObjectFormatPlugins(block []string, indent string) ([]string, bool) {
func rewriteObjectFormatPluginsToDependencies(block []string, indent string) ([]string, bool) {
var result []string
result = append(result, indent+"dependencies:")

Expand Down
Loading