Skip to content

Improve DDUw: scan artifact constants and recognize non-DDUw PR closures #25814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 11, 2026
+9 −0
Merged

Improve DDUw: scan artifact constants and recognize non-DDUw PR closures #25814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3175c4c
Initial plan
Copilot Apr 11, 2026
9fc8dc9
fix: improve DDUw artifact constant scanning and non-DDUw PR recognit…
Copilot Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/daily-doc-healer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ repo:${{ github.repository }} is:issue is:closed label:documentation closed:>=YY
For each issue found:
- Record the issue number, title, body, and closing date.
- Check whether a DDUw-created PR (label `documentation automation`, title prefix `[docs]`) was merged that references or addresses the issue in the same time window. If such a PR exists, DDUw likely already handled it — skip this issue.
- If no DDUw `[docs]` PR references the issue, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found, verify the documentation change it made is complete and skip the issue.
Comment on lines 88 to +89
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions say to identify DDUw PRs by label documentation automation, but the workflow’s own PR creation config uses two labels: documentation and automation (and DDUw’s workflow matches this). As written, this label name likely won’t match real PRs and could cause DDUw-handled issues to be reprocessed; suggest updating the text to check for both labels (or align with the configured labels).

Suggested change
- Check whether a DDUw-created PR (label `documentation automation`, title prefix `[docs]`) was merged that references or addresses the issue in the same time window. If such a PR exists, DDUw likely already handled it — skip this issue.
- If no DDUw `[docs]` PR references the issue, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found, verify the documentation change it made is complete and skip the issue.
- Check whether a DDUw-created PR (labels `documentation` and `automation`, title prefix `[docs]`) was merged that references or addresses the issue in the same time window. If such a PR exists, DDUw likely already handled it — skip this issue.
- If no DDUw PR matching those labels and the `[docs]` title prefix references the issue, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found, verify the documentation change it made is complete and skip the issue.

Copilot uses AI. Check for mistakes.

Comment on lines +89 to 90
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new step asks the agent to find merged PRs that close/fix an issue via closes #NNN text in the PR body, but it doesn’t specify how to search (query, time window, repo scope). To make this actionable and avoid missing matches, consider adding an explicit search_pull_requests example query (including is:merged and the same 7‑day window) that searches for the exact strings (e.g. "closes #NNN" OR "fixes #NNN" OR "resolves #NNN").

Suggested change
- If no DDUw `[docs]` PR references the issue, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). If such a PR is found, verify the documentation change it made is complete and skip the issue.
- If no DDUw `[docs]` PR references the issue, also search for any merged PR that closes or fixes the issue by number (e.g. `closes #NNN`, `fixes #NNN`, `resolves #NNN` in the PR body). Use `search_pull_requests` with an explicit query in the same repo and 7-day window, for example:

repo:${{ github.repository }} is:pr is:merged merged:>=YYYY-MM-DD ("closes #NNN" OR "fixes #NNN" OR "resolves #NNN")


Replace `YYYY-MM-DD` with the date 7 days ago and `NNN` with the issue number. If such a PR is found, verify the documentation change it made is complete and skip the issue.

Copilot uses AI. Check for mistakes.
If no unaddressed documentation issues are found, call `noop` and stop.

Expand All @@ -106,6 +107,14 @@ For each issue that was NOT addressed by DDUw:
find docs/src/content/docs -name '*.md' -o -name '*.mdx'
```

5. **Artifact constant check**: After reviewing recent commits, run:

```bash
grep -Pn "ArtifactName\s*=" pkg/constants/constants.go pkg/constants/job_constants.go
Copy link

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact-constant scan greps only two specific files. That works today, but it will silently miss new *ArtifactName constants if they’re added to another pkg/constants/*.go file later. Consider widening the command to search the whole pkg/constants package so the check stays future-proof.

Suggested change
grep -Pn "ArtifactName\s*=" pkg/constants/constants.go pkg/constants/job_constants.go
grep -Pn "ArtifactName\s*=" pkg/constants/*.go

Copilot uses AI. Check for mistakes.
```

For each constant found, verify that the artifact name value is listed in `docs/src/content/docs/reference/artifacts.md`. If a constant is missing from the reference page, treat it as a documentation gap and add it.

Only proceed with issues where you can confirm the documentation gap still exists.

---
Expand Down
Loading