-
Notifications
You must be signed in to change notification settings - Fork 359
fix: correct integrity level descriptions and auto-enable cli-proxy for reactions #26154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,10 +103,13 @@ func collectDockerImages(tools map[string]any, workflowData *WorkflowData, actio | |
| } | ||
| } | ||
|
|
||
| // Add cli-proxy sidecar container when the cli-proxy feature flag is enabled | ||
| // Add cli-proxy sidecar container when the cli-proxy is needed (explicitly via | ||
| // cli-proxy feature flag, or implicitly via integrity-reactions feature flag) | ||
| // and the AWF version supports it. Without this, --skip-pull causes AWF to fail | ||
| // because the cli-proxy image was never pulled. | ||
| if isFeatureEnabled(constants.CliProxyFeatureFlag, workflowData) && awfSupportsCliProxy(firewallConfig) { | ||
| cliProxyNeeded := isFeatureEnabled(constants.CliProxyFeatureFlag, workflowData) || | ||
| isFeatureEnabled(constants.IntegrityReactionsFeatureFlag, workflowData) | ||
| if cliProxyNeeded && awfSupportsCliProxy(firewallConfig) { | ||
|
Comment on lines
+106
to
+112
|
||
| cliProxyImage := constants.DefaultFirewallRegistry + "/cli-proxy:" + awfImageTag | ||
| if !imageSet[cliProxyImage] { | ||
| images = append(images, cliProxyImage) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test calls
isFeatureEnabledviaisCliProxyNeeded, which can readGH_AW_FEATURESfrom the environment. To keep the test hermetic (and avoid failures whenGH_AW_FEATURESis set in a developer’s shell/CI), explicitly clear or setGH_AW_FEATURES(e.g.,t.Setenv("GH_AW_FEATURES", "")) at the start of the test.