Skip to content

[jsweep] Clean add_reviewer.cjs #26371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Apr 15, 2026
Merged

[jsweep] Clean add_reviewer.cjs #26371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions actions/setup/js/add_reviewer.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,18 @@

/**
* @typedef {import('./types/handler-factory').HandlerFactoryFunction} HandlerFactoryFunction
* @typedef {import('./types/handler-factory').HandlerConfig} HandlerConfig
* @typedef {import('./types/handler-factory').ResolvedTemporaryIds} ResolvedTemporaryIds
* @typedef {import('./types/handler-factory').HandlerResult} HandlerResult
*/

/**
* @typedef {{ reviewers?: Array<string|null|undefined|false>, pull_request_number?: number|string }} AddReviewerMessage
*/

/** @type {string} Safe output type handled by this module */
const HANDLER_TYPE = "add_reviewer";

const { processItems } = require("./safe_output_processor.cjs");
const { getErrorMessage } = require("./error_helpers.cjs");
const { getPullRequestNumber } = require("./pr_helpers.cjs");
Expand Down Expand Up @@ -32,9 +42,9 @@ async function main(config = {}) {
let processedCount = 0;

/**
* @param {Object} message - The add_reviewer message to process
* @param {Object} resolvedTemporaryIds - Map of temporary IDs to {repo, number}
* @returns {Promise<Object>} Result with success/error status
* @param {AddReviewerMessage} message - The add_reviewer message to process
* @param {ResolvedTemporaryIds} resolvedTemporaryIds - Map of temporary IDs to {repo, number}
* @returns {Promise<HandlerResult>} Result with success/error status
*/
return async function handleAddReviewer(message, resolvedTemporaryIds) {
if (processedCount >= maxCount) {
Expand Down
Loading