Skip to content

feat: add lean ecosystem entry to ecosystem_domains.json #26424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 15, 2026
+4 −1
Merged

feat: add lean ecosystem entry to ecosystem_domains.json #26424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
371b03b
Initial plan
Copilot Apr 15, 2026
5f4782a
feat: add lean ecosystem entry to ecosystem_domains.json (#issue)
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/content/docs/reference/network.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Mix ecosystem identifiers with specific domains for fine-grained control:
| `default-safe-outputs` | Compound: `defaults` + `dev-tools` + `github` + `local` — recommended baseline for `safe-outputs.allowed-domains` |
| `containers` | Docker Hub, GitHub Container Registry, Quay |
| `linux-distros` | Debian, Alpine, and other Linux package repositories |
| `dotnet`, `dart`, `go`, `haskell`, `java`, `julia`, `node`, `perl`, `php`, `python`, `ruby`, `rust`, `swift` | Language-specific package managers and registries |
| `dotnet`, `dart`, `go`, `haskell`, `java`, `julia`, `lean`, `node`, `perl`, `php`, `python`, `ruby`, `rust`, `swift` | Language-specific package managers and registries |
| `deno` | Deno runtime (`deno.land`, `jsr.io`, `*.jsr.io`, `googleapis.deno.dev`, `fresh.deno.dev`) |
| `terraform` | HashiCorp and Terraform domains |
| `playwright` | Playwright testing framework domains (see [Playwright Reference](/gh-aw/reference/playwright/)) |
Expand Down
1 change: 1 addition & 0 deletions pkg/workflow/data/ecosystem_domains.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@
],
"julia": ["pkg.julialang.org", "*.pkg.julialang.org", "julialang.org", "julialang-s3.julialang.org", "storage.julialang.net"],
"kotlin": ["download.jetbrains.com", "ge.jetbrains.com", "packages.jetbrains.team", "kotlin.bintray.com", "maven.pkg.jetbrains.space"],
"lean": ["elan.lean-lang.org", "lean-lang.org", "leanprover.github.io", "reservoir.lean-lang.org", "static.lean-lang.org"],
"linux-distros": [
"deb.debian.org",
"security.debian.org",
Expand Down
2 changes: 2 additions & 0 deletions pkg/workflow/domains.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ func getDomainsFromRuntimes(runtimes map[string]any) []string {
// - "haskell": Haskell ecosystem
// - "java": Java/Maven/Gradle
// - "kotlin": Kotlin/JetBrains
// - "lean": Lean 4/Lake/Reservoir
// - "linux-distros": Linux distribution package repositories
// - "node": Node.js/NPM/Yarn
// - "perl": Perl/CPAN
Expand Down Expand Up @@ -355,6 +356,7 @@ var ecosystemPriority = []string{
"java", // before "chrome" — maven.google.com and dl.google.com are Java domains, not chrome domains
"chrome",
"kotlin",
"lean",
"linux-distros",
Comment on lines 356 to 360
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new lean ecosystem identifier is now supported (added to ecosystemPriority and the public doc comment), but there’s no unit test asserting that GetAllowedDomains expands lean to the expected domains and that GetDomainEcosystem maps a representative Lean domain back to lean. Adding a small test case (similar to other ecosystem expansion tests) would prevent regressions if the JSON data or priority order changes.

Copilot uses AI. Check for mistakes.
"local",
"node",
Expand Down
Loading