Align Gemini AWF proxy auth with gh-aw-firewall (remove unsupported GOOGLE_API_KEY mapping)#26559
Align Gemini AWF proxy auth with gh-aw-firewall (remove unsupported GOOGLE_API_KEY mapping)#26559
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/65da78ce-391a-4e0c-9b23-71eb231b4992 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Hey This PR looks ready for maintainer review. 🟢
|
|
@copilot review this fix by investigating the gh-aw-firewall sources |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8de9e6c1-7d1f-48b0-8f7f-df4574244374 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/8de9e6c1-7d1f-48b0-8f7f-df4574244374 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Reviewed against Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Smoke Gemini failures were reviewed against
github/gh-aw-firewallsource, and this PR was corrected to match the firewall’s actual Gemini auth behavior.The previous approach in this PR assumed a key-name mismatch and added
GEMINI_API_KEY -> GOOGLE_API_KEYmirroring. After investigation, that assumption was incorrect for AWF: the API proxy sidecar usesGEMINI_API_KEYfor Gemini authentication.Changes Made
pkg/workflow/gemini_engine.go:GEMINI_API_KEYintoGOOGLE_API_KEYGOOGLE_API_KEYfrom Gemini required secret handlingGOOGLE_API_KEYfrom AWF--exclude-envset for Geminipkg/workflow/gemini_engine_test.gothat assertedGOOGLE_API_KEYbehavior.Validation
pkg/workflowpass.make agent-finishstill reports an existing unrelated timeout inpkg/cli(TestFetchIncludeFromSource_SectionExtraction).