Skip to content

Enable BYOK Copilot by default with explicit false opt-out#26962

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/enable-byok-copilot-by-default
Closed

Enable BYOK Copilot by default with explicit false opt-out#26962
Copilot wants to merge 1 commit intomainfrom
copilot/enable-byok-copilot-by-default

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 17, 2026

Summary

Enable byok-copilot by default and allow disabling it explicitly with features.byok-copilot: false.

Changes

  • Updated isFeatureEnabled to treat byok-copilot as enabled by default when not explicitly set.
  • Preserved explicit opt-out behavior via frontmatter boolean false (including case-insensitive feature key matching already supported by existing logic).
  • Added/updated workflow tests for:
    • default-on BYOK behavior
    • explicit disable behavior
    • implicit cli-proxy implications under default-on BYOK
    • copilot installer/model fallback expectations under default-on BYOK
  • Updated docs to reflect new default and opt-out behavior:
    • /home/runner/work/gh-aw/gh-aw/docs/src/content/docs/reference/frontmatter.md
    • /home/runner/work/gh-aw/gh-aw/docs/src/content/docs/reference/glossary.md

Validation

  • Ran selective tests for affected workflow and Copilot areas (all passing):
    • go test -v -run 'TestIsFeatureEnabled|TestCopilotInstallerByokFeatureUsesLatestVersion|TestCopilotFallbackModelMapsToNativeEnvVar|TestCopilotEngineByokFeatureSetsDummyAPIKey|TestBuildAWFArgsCLIProxy' ./pkg/workflow/
    • go test -v -run 'TestCopilot' ./pkg/workflow/
    • go test -v -run 'TestCopilotGitHubRemotePersonalAccessTokenExport|TestCopilotDetectionDefaultModel' ./pkg/workflow/
  • Ran make agent-finish before commit; existing unrelated timeout persists in pkg/cli test suite (FAIL github.com/github/gh-aw/pkg/cli 600s) consistent with baseline run.
  • Ran parallel_validation:
    • Code Review: no comments
    • CodeQL: 0 alerts (go analysis skipped due oversized database)

Copilot AI requested a review from pelikhan April 17, 2026 23:55
@pelikhan pelikhan closed this Apr 17, 2026
@github-actions github-actions Bot deleted the copilot/enable-byok-copilot-by-default branch April 25, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants