Fix invalid needs dependencies in ci.yml#27097
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/824daf47-d1a1-4d00-b24e-10b929b99778 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/824daf47-d1a1-4d00-b24e-10b929b99778 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 18, 2026 22:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Cleans up the GitHub Actions CI workflow by removing stale needs dependencies that referenced jobs which no longer exist, fixing workflow validation failures (job-needs).
Changes:
- Removed
needs: validate-yamlfromjs-integration-live-api,sh-difc-proxy, andsh-gh-host-pr-checkout-repro. - Removed
needs: buildfromintegration-marketplace-compile.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | Removes invalid needs references so the workflow DAG validates and runs. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
743
to
746
| if: ${{ needs.changes.outputs.has_changes == 'true' && (false) }} | ||
| needs: | ||
| - changes | ||
| - build | ||
| runs-on: ubuntu-latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.ymlcontained staleneedsreferences to jobs that no longer exist, causing workflow validation failures (job-needs). This change removes those invalid dependencies so the workflow graph is internally consistent.Workflow dependency cleanup
needs: validate-yamlfrom:js-integration-live-apish-difc-proxysh-gh-host-pr-checkout-reproneeds: buildfrom:integration-marketplace-compileNet effect
changeswhere intended, without introducing new execution dependencies.