chore: Improve Agentic Observability Kit with portfolio review and visual diagnostics#27511
Merged
chore: Improve Agentic Observability Kit with portfolio review and visual diagnostics#27511
Conversation
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request. File |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/2d8f879b-c43c-4347-8066-0fc6bccc70ef Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates repository portfolio review into the Agentic Observability Kit, adds a structured visual diagnostics/reporting model, and updates documentation/navigation while removing the standalone Portfolio Analyst workflow.
Changes:
- Extend
agentic-observability-kitworkflow prompt to include portfolio review and 4 required Python-generated charts. - Add a new docs pattern page for the Agentic Observability Kit and link it from the docs sidebar.
- Remove the deprecated
portfolio-analystworkflow (and its compiled lock file) and update the agent-factory status list accordingly.
Show a summary per file
| File | Description |
|---|---|
| docs/src/content/docs/patterns/central-repo-ops.mdx | Simplifies the CentralRepoOps intro text. |
| docs/src/content/docs/patterns/agentic-observability-kit.md | New documentation page describing scope, deployment models, metrics, and visual diagnostics. |
| docs/src/content/docs/agent-factory-status.mdx | Removes the “Automated Portfolio Analyst” entry from the workflow inventory table. |
| docs/astro.config.mjs | Adds “Agentic Observability Kit” to the Design Patterns sidebar navigation. |
| .github/workflows/portfolio-analyst.md | Deletes the standalone Portfolio Analyst workflow definition. |
| .github/workflows/portfolio-analyst.lock.yml | Deletes the compiled lock file for the removed workflow. |
| .github/workflows/agentic-observability-kit.md | Updates the workflow prompt to include portfolio review + visual diagnostics and imports chart support. |
| .github/workflows/agentic-observability-kit.lock.yml | Updates the compiled lock file (but currently appears out of sync with the new workflow requirements). |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (2)
.github/workflows/agentic-observability-kit.lock.yml:31
- The compiled lock file appears out of sync with the updated workflow: the resolved manifest
Imports:section does not includeshared/trending-charts-simple.md, even though the.mdworkflow now imports it. That will prevent the Python/chart setup from running (and may leaveGH_AW_INFO_ALLOWED_DOMAINSwithoutpython). Re-rungh aw compileafter updating the workflow so the lock file’s manifest, allowed domains, and steps reflect the new import.
This issue also appears on line 468 of the same file.
# Resolved workflow manifest:
# Imports:
# - shared/daily-audit-discussion.md
# - shared/reporting.md
#
.github/workflows/agentic-observability-kit.lock.yml:470
- The workflow prompt now requires uploading 4 charts via
upload_asset, but the generated Safe Outputs config JSON here does not include anupload_assetentry. As a result the agent run won’t have theupload_assettool available and the report can’t embed the required visuals. Addupload_asset/upload-assetconfiguration (max >= 4, allowed extensions, etc.) and recompile the workflow so this JSON includes it.
cat > "${RUNNER_TEMP}/gh-aw/safeoutputs/config.json" << 'GH_AW_SAFE_OUTPUTS_CONFIG_07ee5f63c5cf601f_EOF'
{"create_discussion":{"category":"audits","close_older_discussions":true,"expires":168,"fallback_to_issue":true,"max":1,"title_prefix":"[observability] "},"create_issue":{"close_older_issues":true,"labels":["agentics","warning","observability"],"max":1,"title_prefix":"[observability escalation] "},"create_report_incomplete_issue":{},"mentions":{"enabled":false},"missing_data":{},"missing_tool":{},"noop":{"max":1,"report-as-issue":"false"},"report_incomplete":{}}
GH_AW_SAFE_OUTPUTS_CONFIG_07ee5f63c5cf601f_EOF
- Files reviewed: 8/8 changed files
- Comments generated: 3
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Resolved in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
✅ Smoke CI completed successfully! |
This comment has been minimized.
This comment has been minimized.
Contributor
|
✅ Smoke CI completed successfully! |
This comment has been minimized.
This comment has been minimized.
Contributor
|
✅ Smoke CI completed successfully! |
Contributor
Contributor
|
Hey One thing to consider before merging:
If you'd like to delegate this to an agent:
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e756ba11-b359-4764-b683-04f21344b1d5 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e756ba11-b359-4764-b683-04f21344b1d5 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
pelikhan
reviewed
Apr 21, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Already resolved in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.