Conversation
Adds specification-driven tests derived from README.md specifications for actionpins (type structure, thread safety), agentdrain (Coordinator.AnalyzeEvent, weights persistence, AnomalyDetector.Analyze, type field validation), and cli (ValidateWorkflowName, GetVersion, IsRunningInCI, DetectShell, ShellType constants, ValidEngineNames, artifact set validation, ExtractWorkflow* functions). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pelikhan
deleted the
spec-enforcer/2026-04-21-actionpins-agentdrain-cli-d54f91929d0f1355
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR adds specification-driven tests for the following packages (round-robin run #1, packages 0–2):
actionpinsActionPin,ActionYAMLInput,ActionPinsData), Thread SafetyagentdrainCoordinator.AnalyzeEvent,SaveWeightsJSON/LoadWeightsJSON,AnomalyDetector.Analyze), Types (Cluster,MatchResult,AnomalyReport,Snapshot)cliValidateWorkflowName,GetVersion,IsRunningInCI,DetectShell,ValidEngineNames,ValidArtifactSetNames,ValidateArtifactSets,ExtractWorkflowDescription,ExtractWorkflowEngine,ExtractWorkflowPrivate), Types (ShellTypeconstants), Design DecisionsTest Derivation
All tests are derived from README.md specifications, not from implementation source code. Only exact function signatures and import paths were read from source files.
Spec-Implementation Mismatches
agentdrain:miner.ClusterCount()is documented in the spec's code example block but is not implemented — onlyminer.Clusters()exists. No test was written for the missing method; it is noted here for awareness.Round-Robin State
actionpins,agentdrain,cliconsole,constants,envutilAuto-generated by Package Specification Enforcer workflow — run §24718241481