Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification Test Enforcement
This PR adds specification-driven tests for the following packages, derived from their README.md specifications.
actionpinsagentdraincliTest Derivation
All tests are derived from README.md specifications, not from implementation source code. Minimal source reads were limited to exact function signatures and import paths.
New Tests Added
actionpinsTestSpec_PublicAPI_ResolveActionPin_EmbeddedMatch— validates the "Embedded-only lookup from bundled pin data" path returns a pinned reference containing the correct SHATestSpec_PublicAPI_GetActionPins_SPEC_MISMATCH— documents and validates the spec gap (see Mismatches below)agentdrainTestSpec_PublicAPI_Coordinator_TrainEvent— explicitly validatesCoordinator.TrainEventroutes events and returns aMatchResultwith correct stage (previously only tested indirectly)TestSpec_PublicAPI_Coordinator_LoadDefaultWeights— validatesLoadDefaultWeightsdoes not error on a fresh coordinatorTestSpec_PublicAPI_Miner_ClusterCount_SPEC_MISMATCH— documents the spec gap and validates equivalent behavior vialen(Clusters())cliTestSpec_PublicAPI_GetAllCodemods— validates each returnedCodemodhas non-emptyID,Name,Description, and non-nilApplyTestSpec_PublicAPI_ResolveArtifactFilter— validates"all"returns nil (no filter), empty input returns nil, and a named set expands to concrete artifact namesTestSpec_PublicAPI_GroupRunsByWorkflow— validates flat run slice is correctly grouped byWorkflowNameSpec-Implementation Mismatches
actionpinsGetActionPins() []ActionPinis documented in the README ("Returns all loaded pins") but not implemented. OnlyGetActionPinsByRepo(repo string)exists.agentdrainminer.ClusterCount()is shown in the README usage example but the method does not exist onMiner. Uselen(miner.Clusters())as the equivalent.Round-Robin State
actionpins,agentdrain,cliconsole,constants,envutil(indices 3–5)Auto-generated by Package Specification Enforcer workflow — Run §24774139718