Skip to content

Update smoke-ci haiku cache-memory behavior and issue body count #27849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 22, 2026
+5 −4
Merged

Update smoke-ci haiku cache-memory behavior and issue body count #27849

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aaf8a3
Update smoke-ci to persist haiku count in issue body
Copilot Apr 22, 2026
ddc7d7d
Clarify smoke-ci haiku cache filename timestamp format
Copilot Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/smoke-ci.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,11 @@ strict: true
---

For all events, call the tools in this exact order:
1. Use `cache-memory` to write a short JSON record for this run.
2. Use `repo-memory` to write a short markdown run note.
3. Use `create_issue` with temporary ID `aw_smokeci` and include the run URL in the body.
4. Use `update_issue` targeting `aw_smokeci` with `operation: "append"` to add a second line confirming the update succeeded.
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
Comment on lines +57 to +58
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1 assumes /tmp/gh-aw/cache-memory/smoke-ci-haiku/ already exists. On a first run (or after cache eviction), inspecting/listing this directory may fail and break the workflow. Please clarify that if the directory is missing, existing_haiku_count must be set to 0 and the directory should be created before writing the new record.

Suggested change
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` and count how many haiku records already exist; if the directory is missing, set `existing_haiku_count` to `0`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, creating that directory first if it does not already exist, with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).

Copilot uses AI. Check for mistakes.
Comment on lines +57 to +58
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new JSON record format is underspecified: it doesn’t say what fields must be included (e.g., run URL, haiku text, timestamp, existing count) or even whether the filename should end in .json. Without a defined schema/extension, future reads and the file-counting logic can become inconsistent. Please specify the required JSON keys and a consistent filename pattern (including extension).

Suggested change
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many haiku records already exist, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it as a JSON record in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` with a filesystem-safe timestamp filename in `YYYY-MM-DD-HH-MM-SS-sss` format (no `:`).
1. Use `cache-memory` to inspect `/tmp/gh-aw/cache-memory/smoke-ci-haiku/`, count how many existing haiku record files match `*.json`, then save that count as `existing_haiku_count`.
2. Create a new haiku for this run and use `cache-memory` to save it in `/tmp/gh-aw/cache-memory/smoke-ci-haiku/` as a JSON object with exactly these required keys: `run_url`, `haiku_text`, `timestamp`, and `existing_haiku_count`. Use the consistent filename pattern `YYYY-MM-DD-HH-MM-SS-sss.json` (filesystem-safe, no `:`).

Copilot uses AI. Check for mistakes.
3. Use `repo-memory` to write a short markdown run note.
4. Use `create_issue` with temporary ID `aw_smokeci` and include in the body: the run URL, the generated haiku text, and `existing_haiku_count`.
5. Use `update_issue` targeting `aw_smokeci` with `operation: "append"` to add a second line confirming the update succeeded.

For pull_request events, then call these safe output tools in this exact order:
1. `add_comment` with a short smoke-ci message that includes the run URL.
Expand Down
Loading