Skip to content

Add daily skill-optimizer workflow with artifact handoff and 3-improvement issue output#27948

Merged
pelikhan merged 3 commits intomainfrom
copilot/create-daily-workflow-for-skill-optimizer
Apr 23, 2026
Merged

Add daily skill-optimizer workflow with artifact handoff and 3-improvement issue output#27948
pelikhan merged 3 commits intomainfrom
copilot/create-daily-workflow-for-skill-optimizer

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

This introduces a daily agentic workflow that runs fastxyz/skill-optimizer in a dedicated pre-agent job, then uses its artifact output to drive one actionable issue with exactly three improvement recommendations.

  • Workflow topology (separate execution + handoff)

    • Added daily-skill-optimizer.md with a dedicated skill_optimizer job (needs: [activation]).
    • The job clones/builds fastxyz/skill-optimizer, runs initialization + benchmark/dry-run flow, and writes structured results (summary.json) plus logs.
    • Results are uploaded as a named artifact and downloaded in the agent phase for analysis.
  • Agent behavior (issue creation contract)

    • Configured safe-outputs.create-issue with a single-issue cap.
    • Prompt now requires:
      • exactly one created issue,
      • exactly three numbered improvements,
      • evidence tied to artifact files,
      • run mode/status from summary.json.
  • Compiled workflow output

    • Added the generated lock file (daily-skill-optimizer.lock.yml) aligned to the new markdown workflow definition.
jobs:
  skill_optimizer:
    needs: [activation]
    steps:
      - uses: actions/upload-artifact@v7
        with:
          name: skill-optimizer-results

steps:
  - uses: actions/download-artifact@v8
    with:
      name: skill-optimizer-results
      path: /tmp/gh-aw/skill-optimizer-results

🤖 Smoke CI scheduled run completed — https://github.com/github/gh-aw/actions/runs/24814493092

Generated by Smoke CI · ● 436.4K ·

@pelikhan pelikhan marked this pull request as ready for review April 23, 2026 03:12
Copilot AI review requested due to automatic review settings April 23, 2026 03:12
@pelikhan pelikhan merged commit 963e027 into main Apr 23, 2026
@pelikhan pelikhan deleted the copilot/create-daily-workflow-for-skill-optimizer branch April 23, 2026 03:12
This was referenced Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new daily Agentic Workflows pipeline that runs fastxyz/skill-optimizer in a dedicated pre-agent job, hands results to the agent via an artifact, and has the agent create a single issue containing exactly three improvement recommendations.

Changes:

  • Introduces a new daily-skill-optimizer.md workflow with a skill_optimizer job that clones/builds/runs fastxyz/skill-optimizer and uploads logs + summary.json as an artifact.
  • Configures the agent phase to download the artifact and enforce a “one issue / exactly three improvements / evidence from artifacts” contract via Safe Outputs.
  • Adds the compiled workflow output (daily-skill-optimizer.lock.yml) aligned to the markdown workflow definition.
Show a summary per file
File Description
.github/workflows/daily-skill-optimizer.md Defines the pre-agent skill_optimizer job, artifact handoff, and agent prompt + safe-outputs constraints for issue creation.
.github/workflows/daily-skill-optimizer.lock.yml Generated compiled workflow reflecting the new markdown workflow topology and configuration.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 3

Comment on lines +40 to +42
env:
OPENROUTER_API_KEY: ${{ secrets.OPENROUTER_API_KEY }}
run: |
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPENROUTER_API_KEY is set at the step level, so it will also be visible to npm ci/npm run build and other third-party code executed in this step (including npm lifecycle scripts). To reduce secret exposure, consider scoping this secret to only the benchmark invocation (e.g., export it immediately before the non---dry-run run, or move the benchmark run into a separate step with env:).

Copilot uses AI. Check for mistakes.
Comment on lines +45 to +49
RESULT_DIR="/tmp/gh-aw/skill-optimizer-results"
TOOL_DIR="$RESULT_DIR/skill-optimizer-src"
mkdir -p "$RESULT_DIR"

git clone --depth 1 https://github.com/fastxyz/skill-optimizer "$TOOL_DIR" >"$RESULT_DIR/clone.log" 2>&1
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent phase requires summary.json, but with set -euo pipefail a failure in git clone/npm ci/npm run build will exit the step before summary.json is written. Consider ensuring summary.json is always produced (e.g., via a trap/finally block that writes a failure summary including which phase failed), and capture exit codes for clone/build similarly to init/run.

Copilot uses AI. Check for mistakes.
uses: actions/upload-artifact@v7.0.1
with:
name: skill-optimizer-results
path: /tmp/gh-aw/skill-optimizer-results
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The artifact upload path points at /tmp/gh-aw/skill-optimizer-results, which also contains the cloned skill-optimizer-src checkout (and its node_modules after npm ci). This can greatly inflate artifact size and slow/fail uploads. Consider keeping the tool checkout outside the artifact directory or deleting skill-optimizer-src before uploading, and/or uploading only the specific result files needed by the agent (e.g., summary.json + logs).

Suggested change
path: /tmp/gh-aw/skill-optimizer-results
path: |
/tmp/gh-aw/skill-optimizer-results/summary.json
/tmp/gh-aw/skill-optimizer-results/clone.log
/tmp/gh-aw/skill-optimizer-results/npm-ci.log
/tmp/gh-aw/skill-optimizer-results/npm-build.log
/tmp/gh-aw/skill-optimizer-results/init.log
/tmp/gh-aw/skill-optimizer-results/run.log
/tmp/gh-aw/skill-optimizer-results/benchmark.log

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants