Skip to content

Pre-consolidation analysis for observability/audit workflow overlap#28006

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/consolidate-optimization-work
Closed

Pre-consolidation analysis for observability/audit workflow overlap#28006
Copilot wants to merge 3 commits intomainfrom
copilot/consolidate-optimization-work

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

Adds two scratchpad reference documents capturing the pre-consolidation state before any workflow or expression-subsystem merging begins.

scratchpad/observability-audit-consolidation.md

Pre-consolidation analysis of the five overlapping observability/audit workflows (Kit, Audit, DOR, WHM, SOH):

  • Table 1 — What each workflow analyzes across 16 dimensions (data model, time window, episode model, firewall/MCP/safe-output/portfolio coverage, chart generation)
  • Table 2 — Configuration snapshot (engine, strict, timeout, tools, permissions, tracker-id)
  • Table 3 — Output artifacts (discussions, escalation issues, charts, repo/cache-memory writes)
  • Table 4 — Import dependency matrix
  • Table 5 — KEEP vs. CONSOLIDATE overlap map with preference winner per capability
  • Table 6 — Six specific conflicts requiring resolution, including the [observability] discussion prefix collision where DOR's daily close-older-discussions silently kills Kit's 7-day report
  • Table 7 — Engine selection rationale and downgrade candidates (DOR is strongest: file-presence checking doesn't need a reasoning-heavy model)
  • Table 8 + Appendix — Four distinct concerns mapped to owners, plus per-workflow unique-signal inventories

scratchpad/expression-consolidation.md

Pre-consolidation analysis of the pkg/workflow expression subsystem:

  • File inventory (9 production files, ~2,896 lines; 8 test files, ~4,500 lines) with responsibilities
  • Regex duplication map: 9 private duplicates in expression_safety_validation.go and 2 in expression_syntax_validation.go — all byte-for-byte identical to patterns already in expression_patterns.go
  • Startup cost table: ~38 compiled regexes today vs. ~27 after consolidation (11 wasted compilations)
  • Dependency graph across all 9 expression files
  • Optimizer rule table (18 boolean-algebra rules with safety constraints)
  • 3-step consolidation plan with explicit rename tables and risk assessment (no behavioral changes, no test changes needed)

Copilot AI and others added 3 commits April 23, 2026 06:19
… analysis tables

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/888453a4-18d0-4e0f-b748-bdcee844096b

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Apr 23, 2026
@mnkiefer mnkiefer changed the title docs: pre-consolidation analysis for observability/audit workflow overlap pre-consolidation analysis for observability/audit workflow overlap Apr 23, 2026
@mnkiefer mnkiefer changed the title pre-consolidation analysis for observability/audit workflow overlap Pre-consolidation analysis for observability/audit workflow overlap Apr 23, 2026
@mnkiefer
Copy link
Copy Markdown
Collaborator

@mnkiefer mnkiefer closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants