Skip to content

fix(design-decision-gate): add git ls-remote permission, raise turn limit to 20, add MCP fallback #28353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 24, 2026
+29 −22
Merged

fix(design-decision-gate): add git ls-remote permission, raise turn limit to 20, add MCP fallback #28353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
682ed37
Initial plan
Copilot Apr 24, 2026
8e5d291
fix: design-decision-gate bash permissions, turn limit, and fallback …
Copilot Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions .github/workflows/design-decision-gate.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 11 additions & 5 deletions .github/workflows/design-decision-gate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ permissions:
issues: read
engine:
id: claude
max-turns: 15
max-turns: 20
safe-outputs:
add-comment:
max: 2
Expand Down Expand Up @@ -44,6 +44,7 @@ tools:
bash:
- "git diff:*"
- "git log:*"
- "git ls-remote:*"
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing git ls-remote:* grants the agent a generic network-capable git command that can be invoked against arbitrary URLs (e.g., git ls-remote https://...), which expands the workflow’s egress surface beyond the stated need (origin "copilot/*"). Consider narrowing this permission to only the required invocation(s), such as scoping it to the origin remote (or even the copilot/* pattern) if the tool-allowlist syntax supports it, to reduce unintended network access.

Suggested change
- "git ls-remote:*"
- "git ls-remote:origin copilot/*"

Copilot uses AI. Check for mistakes.
- "git show:*"
- "cat:*"
- "grep:*"
Expand Down Expand Up @@ -112,7 +113,7 @@ You are the Design Decision Gate, an AI agent that enforces a culture of "decide
- **Pull Request**: #${{ github.event.pull_request.number || github.event.inputs.pr_number }}
- **Event**: ${{ github.event_name }}
- **Actor**: ${{ github.actor }}
- **Hard Turn Budget**: 15 turns maximum (stop early when done)
- **Hard Turn Budget**: 20 turns maximum (stop early when done)

### Mandatory Efficiency Rules

Expand All @@ -122,9 +123,14 @@ You are the Design Decision Gate, an AI agent that enforces a culture of "decide
- `pr.diff`
- `design-gate-config.yml`
- `adr-prefetch-summary.json`
2. Do **not** perform broad exploration. Only fetch extra data if a required field is missing from pre-fetched files.
3. Call exactly one final safe output action (`add-comment`, `push-to-pull-request-branch`, or `noop`) and then stop.
4. If you have enough evidence to decide, stop immediately. Do not gather optional data.
2. If a pre-fetched file is missing or returns a permission error, fall back to the equivalent GitHub MCP tool immediately (do not retry the file read):
- Missing `pr.json` → `mcp__github__get_pull_request`
- Missing `pr-files.json` → `mcp__github__get_pull_request_files`
- Missing `pr.diff` → `mcp__github__get_pull_request_diff`
- Missing `adr-prefetch-summary.json` → compute manually from PR files and labels
3. Do **not** perform broad exploration. Only fetch extra data if a required field is missing from pre-fetched files.
4. Call exactly one final safe output action (`add-comment`, `push-to-pull-request-branch`, or `noop`) and then stop.
5. If you have enough evidence to decide, stop immediately. Do not gather optional data.

## Step 1: Determine if This PR Requires an ADR

Expand Down
Loading