Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a --use-local-secrets flag to both run and trial commands, enabling users to temporarily push API key secrets from their local environment to repositories for workflow execution. The feature automatically cleans up these secrets after completion.
- Added
--use-local-secretsflag support torunandtrialcommands - Refactored
determineAndAddEngineSecretto acceptEngineConfiginstead of fullWorkflowData - Introduced conditional secret tracking and cleanup based on the new flag
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/cli/trial_command.go | Added --use-local-secrets flag, --repo alias, conditional secret handling, and refactored engine secret determination |
| pkg/cli/run_command.go | Implemented secret pushing/cleanup logic for run command with engine detection |
| pkg/cli/commands_test.go | Updated test calls to include new pushSecrets parameter |
| docs/src/content/docs/tools/cli.md | Added documentation for --use-local-secrets flag and updated examples |
| cmd/gh-aw/main.go | Added --use-local-secrets flag to run command |
Comments suppressed due to low confidence (1)
pkg/cli/trial_command.go:955
- Debug log statement left in production code. This should be removed or placed behind a verbose/debug flag.
fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("DEBUG: engineOverride parameter = '%s'", engineOverride)))
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--use-local-secretsflag togh aw runandgh aw trialcommandsKey Changes
--use-local-secretsHow It Works
Security Considerations