feat: deprecate features.mcp-cli, enable MCP CLI mounting by default#28448
Closed
feat: deprecate features.mcp-cli, enable MCP CLI mounting by default#28448
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/b51a0333-4d4f-4253-9d0b-9fe32766e732 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 25, 2026 12:11
View session
Copilot AI
added a commit
that referenced
this pull request
Apr 25, 2026
…orkflow The workflow was failing because: 1. AWF container setup takes ~19 minutes, leaving Claude only ~1 minute within the 20-minute step timeout 2. The default 60-second tool/bash timeout was too short for analysis ops Fix: - Increase timeout-minutes from 20 to 45 (matching api-consumption-report) - Add tools.timeout: 300 to allow 5-minute bash/MCP operations This aligns with similar complex analysis workflows (api-consumption-report.md uses timeout-minutes: 45 and tools.timeout: 300). Recompile lock file with updated timeouts: - BASH_MAX_TIMEOUT_MS: 300000 (was 60000) - MCP_TOOL_TIMEOUT: 300000 (was 60000) - timeout-minutes: 45 on Execute Claude Code CLI step (was 20) Fixes #28448 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9d239f17-6126-420a-ad05-efec33ca9f43 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
features.mcp-cli: truewas required alongsidetools.mount-as-clis: trueto activate MCP CLI mounting. The feature flag gate is removed — MCP CLI mounting is now always active.mount-as-clis: trueis still required to mount user-facing servers;safeoutputs/mcpscriptscontinue to be always-mounted when enabled.Code changes
mcp_cli_mount.go— RemoveisFeatureEnabled(MCPCLIFeatureFlag)gate fromgetMCPCLIServerNames(); remove feature flag synthesis frombuildCLIWorkflowDataForMounts()(only existed to satisfy the gate)features_validation.go— Emit deprecation warning at compile time whenfeatures.mcp-cliis explicitly setfeature_constants.go—MCPCLIFeatureFlagmarked deprecated in doc commentTest / workflow updates
MCPCLIFeatureFlag: truefrom test fixtures incopilot_engine_test.go,crush_engine_test.go,codex_engine_test.go; updated one expected output (comprehensive with multiple tools) to includeshell(safeoutputs:*)now injected by default when safeoutputs is configured with restricted bashmcp-cli: truefrom all 162 workflow.mdfiles; cleaned up 118 resulting emptyfeatures:sections; recompiled all 202 lock filesBefore / after