Skip to content

feat: deprecate features.mcp-cli, enable MCP CLI mounting by default#28448

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/deprecate-features-mcp-cli
Closed

feat: deprecate features.mcp-cli, enable MCP CLI mounting by default#28448
Copilot wants to merge 1 commit intomainfrom
copilot/deprecate-features-mcp-cli

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 25, 2026

features.mcp-cli: true was required alongside tools.mount-as-clis: true to activate MCP CLI mounting. The feature flag gate is removed — MCP CLI mounting is now always active. mount-as-clis: true is still required to mount user-facing servers; safeoutputs/mcpscripts continue to be always-mounted when enabled.

Code changes

  • mcp_cli_mount.go — Remove isFeatureEnabled(MCPCLIFeatureFlag) gate from getMCPCLIServerNames(); remove feature flag synthesis from buildCLIWorkflowDataForMounts() (only existed to satisfy the gate)
  • features_validation.go — Emit deprecation warning at compile time when features.mcp-cli is explicitly set
  • feature_constants.goMCPCLIFeatureFlag marked deprecated in doc comment

Test / workflow updates

  • Removed MCPCLIFeatureFlag: true from test fixtures in copilot_engine_test.go, crush_engine_test.go, codex_engine_test.go; updated one expected output (comprehensive with multiple tools) to include shell(safeoutputs:*) now injected by default when safeoutputs is configured with restricted bash
  • Removed mcp-cli: true from all 162 workflow .md files; cleaned up 118 resulting empty features: sections; recompiled all 202 lock files

Before / after

# Before — required both flags
features:
  mcp-cli: true   # ← no longer needed, emits deprecation warning if present
tools:
  mount-as-clis: true

# After — just mount-as-clis is sufficient
tools:
  mount-as-clis: true

@pelikhan pelikhan marked this pull request as ready for review April 25, 2026 12:12
Copilot AI review requested due to automatic review settings April 25, 2026 12:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@pelikhan pelikhan closed this Apr 25, 2026
Copilot AI added a commit that referenced this pull request Apr 25, 2026
…orkflow

The workflow was failing because:
1. AWF container setup takes ~19 minutes, leaving Claude only ~1 minute
   within the 20-minute step timeout
2. The default 60-second tool/bash timeout was too short for analysis ops

Fix:
- Increase timeout-minutes from 20 to 45 (matching api-consumption-report)
- Add tools.timeout: 300 to allow 5-minute bash/MCP operations

This aligns with similar complex analysis workflows (api-consumption-report.md
uses timeout-minutes: 45 and tools.timeout: 300).

Recompile lock file with updated timeouts:
- BASH_MAX_TIMEOUT_MS: 300000 (was 60000)
- MCP_TOOL_TIMEOUT: 300000 (was 60000)
- timeout-minutes: 45 on Execute Claude Code CLI step (was 20)

Fixes #28448

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9d239f17-6126-420a-ad05-efec33ca9f43

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants