Conversation
…cs reference Agent-Logs-Url: https://github.com/github/gh-aw/sessions/276d4cb6-d643-4321-a705-e0dadc2f0527 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
…uidance Agent-Logs-Url: https://github.com/github/gh-aw/sessions/276d4cb6-d643-4321-a705-e0dadc2f0527 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Hey A few small things worth noting:
Everything else looks solid: the change is focused, well-described, on-topic, and authored by a core-team agent following the correct process.
|
| @@ -0,0 +1,49 @@ | |||
| --- | |||
There was a problem hiding this comment.
- update trigger restrict to changes to the Astro starlight infrastructure files (package json, css, tsx)
- move docs build and initialization into steps to save turns
There was a problem hiding this comment.
Done in 1419c14:
- Trigger: Added
paths:filter restricting runs to changes indocs/package.json,docs/package-lock.json,docs/src/**/*.css,docs/src/**/*.tsx,docs/src/**/*.astro, anddocs/astro.config.mjs. - Steps: Added pre-run
steps:block — checkout (withpersist-credentials: false), Setup Node.js,npm ci, andnpm run build— so the docs are fully built before the agent starts. The agent prompt now just needs tonpm run preview &and start taking screenshots.
…run steps Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ac2a4691-b9f5-4fd6-abd1-f769e98878ef Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot add steps to launch Astro dev server and wait till it is ready |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/59b1be4f-1d1a-413d-8d82-ce6f0c153b99 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 740b58a. Added two pre-run steps in the frontmatter
The agent prompt now simply says the server is already running, removing the need for any startup turns. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Adds a concrete Playwright-based visual regression workflow example for the Frontend Developer persona and links it from the agentic workflow tool documentation.
Changes:
- Added a new PR-scoped visual regression checker workflow example using Playwright, including pre-run setup/build/dev-server readiness steps.
- Updated agentic workflow documentation to expand Playwright guidance and link to the new example.
- Updated workflow status listing and refreshed the actions/containers lock data to support the new workflow artifacts.
Show a summary per file
| File | Description |
|---|---|
docs/src/content/docs/agent-factory-status.mdx |
Adds the new workflow to the published workflow status table. |
.github/workflows/visual-regression-checker.md |
Introduces the new Playwright visual regression example workflow (frontmatter + agent instructions). |
.github/workflows/visual-regression-checker.lock.yml |
Compiled lock workflow generated from the new .md workflow. |
.github/aw/github-agentic-workflows.md |
Expands Playwright tool documentation and links to the new example. |
.github/aw/actions-lock.json |
Updates the action/container lock entries required by the new compiled workflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (4)
.github/workflows/visual-regression-checker.md:38
actions/checkoutis referenced asactions/checkout@v6here, but other workflows in this repo pin to a specific patch version (e.g.actions/checkout@v6.0.2in.github/workflows/go-pattern-detector.md:20). Pinning the patch version in this example keeps the workflow deterministic and consistent with existing conventions.
- name: Checkout repository
uses: actions/checkout@v6
with:
.github/workflows/visual-regression-checker.md:44
actions/setup-nodeis referenced asactions/setup-node@v6here, but this repo typically pins the patch version (for exampleactions/setup-node@v6.4.0in.github/workflows/daily-multi-device-docs-tester.md:24). Consider pinning the patch version in this example as well to avoid unexpected behavior changes when the major tag moves.
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: '24'
.github/workflows/visual-regression-checker.md:24
- The bash allowlist entry
"curl http://localhost:*"is unusually strict compared to other Playwright/docs workflows here (which generally use"curl*", e.g..github/workflows/daily-multi-device-docs-tester.md:35). With the current pattern, common invocations likecurl -sSf http://localhost:...may not be permitted by the tool allowlist. Consider broadening this to a wildcard form (or explicitly allowing the flag variants you expect) to avoid the agent being blocked during troubleshooting/reporting.
bash:
- "npm *"
- "npx *"
- "node *"
- "curl http://localhost:*"
.github/workflows/visual-regression-checker.md:33
- This workflow runs on
pull_requestfor bothopenedandsynchronize, butsafe-outputs.add-commentdoesn’t enablehide-older-comments. As written, each push to the PR can add another comment, which can get noisy. Consider settinghide-older-comments: true(common in this repo, e.g..github/workflows/ci-doctor.md:25-27) so only the latest report remains visible.
safe-outputs:
add-comment:
max: 1
- Files reviewed: 5/5 changed files
- Comments generated: 2
| engine: copilot | ||
| tools: | ||
| playwright: | ||
| version: "v1.52.0" |
There was a problem hiding this comment.
The Playwright tool is pinned to v1.52.0, which is noticeably behind versions used elsewhere in this repo (e.g. v1.56.1 in .github/workflows/daily-multi-device-docs-tester.md:28-30) and behind the docs site's @playwright/test devDependency (^1.59.1 in docs/package.json:36). For an example intended to be copied, aligning the pinned MCP Playwright version with the repo’s current Playwright version (or explaining the deliberate downgrade) will reduce confusion and avoid API/behavior mismatches.
This issue also appears in the following locations of the same file:
- line 20
- line 31
- line 36
- line 41
| version: "v1.52.0" | |
| version: "v1.56.1" |
| bash: ["*"] | ||
| ``` | ||
| - `playwright:` - Browser automation tools | ||
| - `playwright:` - Browser automation tools for visual regression, accessibility testing, and end-to-end testing. Pin a specific version with `version:` and restrict network access to `local` + `playwright` for security. See [`visual-regression-checker.md`](../../.github/workflows/visual-regression-checker.md) for a minimal pull-request example. |
There was a problem hiding this comment.
The Playwright guidance here says to “restrict network access to local + playwright for security”, but the linked example workflow (visual-regression-checker.md) currently allows defaults and node as well. Either adjust this guidance to reflect that additional network groups may be required/intentional, or tighten the example’s network.allowed to match the recommendation so users don’t get conflicting instructions.
| - `playwright:` - Browser automation tools for visual regression, accessibility testing, and end-to-end testing. Pin a specific version with `version:` and restrict network access to `local` + `playwright` for security. See [`visual-regression-checker.md`](../../.github/workflows/visual-regression-checker.md) for a minimal pull-request example. | |
| - `playwright:` - Browser automation tools for visual regression, accessibility testing, and end-to-end testing. Pin a specific version with `version:` and restrict network access to the minimum required for your workflow—typically `local` + `playwright` for security, but additional groups such as `defaults` or `node` may be needed when the workflow intentionally depends on them. See [`visual-regression-checker.md`](../../.github/workflows/visual-regression-checker.md) for a minimal pull-request example. |
- Add deployment_status trigger section to triggers.md (from #28549) - Add deployment state filter (state:) and NL shorthands - Add deployment incident monitor example - Update Playwright visual regression example with dev server setup pattern (from #28550) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Frontend Developer scenarios (especially visual regression with Playwright) were underserved — Playwright support existed but had no concrete example workflow to guide users.
Changes
New workflow —
.github/workflows/visual-regression-checker.md:pull_requestexample scoped to Astro Starlight infrastructure files with:docs/package.json,docs/package-lock.json,docs/src/**/*.css,docs/src/**/*.tsx,docs/src/**/*.astro, anddocs/astro.config.mjssteps:that checkout the repo, set up Node.js 24, runnpm ci,npm run build, start the Astro dev server (npm run dev &), and pollhttp://localhost:4321/gh-aw/for up to 30 seconds until ready — so the site is fully live before the agent startsv1.52.0defaults+playwright+local+nodebashtooladd-commentsafe-output for the report; falls back tonoopon clean runsAgent instructions — Expanded the
playwright:entry in.github/aw/github-agentic-workflows.mdto explain version pinning and network scope with a direct link to the new example.