Skip to content

[jsweep] Clean action_setup_otlp.cjs #28661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Apr 27, 2026
+27 −2
Merged

[jsweep] Clean action_setup_otlp.cjs #28661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68b5a89
jsweep: clean action_setup_otlp.cjs
github-actions[bot] Apr 27, 2026
c584709
fix: tighten SETUP_START_MS parsing to reject hex/scientific notation
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions actions/setup/js/action_setup_otlp.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ async function run() {

const { sendJobSetupSpan, isValidTraceId, isValidSpanId } = require(path.join(__dirname, "send_otlp_span.cjs"));

const parsedStartMs = parseInt(process.env.SETUP_START_MS || "0", 10);
const startMs = Number.isFinite(parsedStartMs) ? parsedStartMs : 0;
const rawStartMs = process.env.SETUP_START_MS;
const parsedMs = /^\d+$/.test(rawStartMs ?? "") ? Number(rawStartMs) : NaN;
const startMs = Number.isSafeInteger(parsedMs) ? parsedMs : 0;

// Explicitly read INPUT_TRACE_ID and pass it as options.traceId so the
// activation job's trace ID is used even when process.env propagation
Expand Down
24 changes: 24 additions & 0 deletions actions/setup/js/action_setup_otlp.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,30 @@ describe("action_setup_otlp.cjs", () => {

expect(mockSendJobSetupSpan).toHaveBeenCalledWith(expect.objectContaining({ startMs: 0 }));
});

it("should pass startMs=0 when SETUP_START_MS is a partial number string like '123abc'", async () => {
process.env.SETUP_START_MS = "123abc";

await run();

expect(mockSendJobSetupSpan).toHaveBeenCalledWith(expect.objectContaining({ startMs: 0 }));
});

it("should pass startMs=0 when SETUP_START_MS is scientific notation like '1e3'", async () => {
process.env.SETUP_START_MS = "1e3";

await run();

expect(mockSendJobSetupSpan).toHaveBeenCalledWith(expect.objectContaining({ startMs: 0 }));
});

it("should pass startMs=0 when SETUP_START_MS is hex notation like '0x10'", async () => {
process.env.SETUP_START_MS = "0x10";

await run();

expect(mockSendJobSetupSpan).toHaveBeenCalledWith(expect.objectContaining({ startMs: 0 }));
});
});

describe("INPUT_TRACE_ID handling", () => {
Expand Down