feat: remove features.mcp-cli flag, rename mount-as-clis to cli-proxy#28842
feat: remove features.mcp-cli flag, rename mount-as-clis to cli-proxy#28842
Conversation
- Remove MCPCLIFeatureFlag from constants; MCP CLI mounting is now always active when tools.cli-proxy: true is set (no feature flag needed) - Rename tools.mount-as-clis → tools.cli-proxy in ToolsConfig, parser, schema, and all workflow .md files - Remove alwaysCLIMountedServers: safeoutputs and mcpscripts are no longer auto-mounted; they are only mounted when cli-proxy: true is set - Simplify getMCPCLIExcludeFromAgentConfig (no more dual-access exclusion) - Update all test files to use CLIProxy field and remove MCPCLIFeatureFlag - Remove mcp-cli: true from 60+ workflow features blocks - Recompile all lock files Agent-Logs-Url: https://github.com/github/gh-aw/sessions/54c0f788-c290-4ae1-93ab-f3eaaa051b93 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Adds codemod 'mount-as-clis-to-cli-proxy' that: - Renames tools.mount-as-clis → tools.cli-proxy - Removes deprecated features.mcp-cli flag Registered in GetAllCodemods() and covered by 6 test cases. Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e26bc328-2349-4521-887c-e7619d4561e9 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Added in db61398. The
Run it with |
|
@copilot Merge main and recompile |
…es-mcp-cli # Conflicts: # .github/workflows/ace-editor.lock.yml # .github/workflows/agent-performance-analyzer.lock.yml # .github/workflows/agent-persona-explorer.lock.yml # .github/workflows/agentic-observability-kit.lock.yml # .github/workflows/agentic-optimization-kit.lock.yml # .github/workflows/ai-moderator.lock.yml # .github/workflows/api-consumption-report.lock.yml # .github/workflows/approach-validator.lock.yml # .github/workflows/archie.lock.yml # .github/workflows/architecture-guardian.lock.yml # .github/workflows/artifacts-summary.lock.yml # .github/workflows/audit-workflows.lock.yml # .github/workflows/auto-triage-issues.lock.yml # .github/workflows/aw-failure-investigator.lock.yml # .github/workflows/blog-auditor.lock.yml # .github/workflows/bot-detection.lock.yml # .github/workflows/brave.lock.yml # .github/workflows/breaking-change-checker.lock.yml # .github/workflows/changeset.lock.yml # .github/workflows/ci-coach.lock.yml # .github/workflows/ci-doctor.lock.yml # .github/workflows/claude-code-user-docs-review.lock.yml # .github/workflows/cli-consistency-checker.lock.yml # .github/workflows/cli-version-checker.lock.yml # .github/workflows/cloclo.lock.yml # .github/workflows/code-scanning-fixer.lock.yml # .github/workflows/code-simplifier.lock.yml # .github/workflows/codex-github-remote-mcp-test.lock.yml # .github/workflows/commit-changes-analyzer.lock.yml # .github/workflows/constraint-solving-potd.lock.yml # .github/workflows/contribution-check.lock.yml # .github/workflows/copilot-agent-analysis.lock.yml # .github/workflows/copilot-cli-deep-research.lock.yml # .github/workflows/copilot-opt.lock.yml # .github/workflows/copilot-pr-merged-report.lock.yml # .github/workflows/copilot-pr-nlp-analysis.lock.yml # .github/workflows/copilot-pr-prompt-analysis.lock.yml # .github/workflows/copilot-session-insights.lock.yml # .github/workflows/copilot-token-audit.lock.yml # .github/workflows/copilot-token-optimizer.lock.yml # .github/workflows/craft.lock.yml # .github/workflows/daily-architecture-diagram.lock.yml # .github/workflows/daily-assign-issue-to-user.lock.yml # .github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml # .github/workflows/daily-aw-cross-repo-compile-check.lock.yml # .github/workflows/daily-cache-strategy-analyzer.lock.yml # .github/workflows/daily-choice-test.lock.yml # .github/workflows/daily-cli-performance.lock.yml # .github/workflows/daily-cli-tools-tester.lock.yml # .github/workflows/daily-code-metrics.lock.yml # .github/workflows/daily-community-attribution.lock.yml # .github/workflows/daily-compiler-quality.lock.yml # .github/workflows/daily-doc-healer.lock.yml # .github/workflows/daily-doc-updater.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-file-diet.lock.yml # .github/workflows/daily-firewall-report.lock.yml # .github/workflows/daily-firewall-report.md # .github/workflows/daily-function-namer.lock.yml # .github/workflows/daily-hippo-learn.lock.yml # .github/workflows/daily-issues-report.lock.yml # .github/workflows/daily-malicious-code-scan.lock.yml # .github/workflows/daily-mcp-concurrency-analysis.lock.yml # .github/workflows/daily-multi-device-docs-tester.lock.yml # .github/workflows/daily-news.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/daily-otel-instrumentation-advisor.lock.yml # .github/workflows/daily-performance-summary.lock.yml # .github/workflows/daily-regulatory.lock.yml # .github/workflows/daily-rendering-scripts-verifier.lock.yml # .github/workflows/daily-repo-chronicle.lock.yml # .github/workflows/daily-safe-output-integrator.lock.yml # .github/workflows/daily-safe-output-optimizer.lock.yml # .github/workflows/daily-safe-outputs-conformance.lock.yml # .github/workflows/daily-secrets-analysis.lock.yml # .github/workflows/daily-security-observability.lock.yml # .github/workflows/daily-security-red-team.lock.yml # .github/workflows/daily-semgrep-scan.lock.yml # .github/workflows/daily-skill-optimizer.lock.yml # .github/workflows/daily-syntax-error-quality.lock.yml # .github/workflows/daily-team-evolution-insights.lock.yml # .github/workflows/daily-team-status.lock.yml # .github/workflows/daily-testify-uber-super-expert.lock.yml # .github/workflows/daily-token-consumption-report.lock.yml # .github/workflows/daily-workflow-updater.lock.yml # .github/workflows/dead-code-remover.lock.yml # .github/workflows/deep-report.lock.yml # .github/workflows/delight.lock.yml # .github/workflows/dependabot-burner.lock.yml # .github/workflows/dependabot-go-checker.lock.yml # .github/workflows/design-decision-gate.lock.yml # .github/workflows/dev-hawk.lock.yml # .github/workflows/dev.lock.yml # .github/workflows/developer-docs-consolidator.lock.yml # .github/workflows/dictation-prompt.lock.yml # .github/workflows/discussion-task-miner.lock.yml # .github/workflows/docs-noob-tester.lock.yml # .github/workflows/draft-pr-cleanup.lock.yml # .github/workflows/duplicate-code-detector.lock.yml # .github/workflows/example-permissions-warning.lock.yml # .github/workflows/example-workflow-analyzer.lock.yml # .github/workflows/firewall-escape.lock.yml # .github/workflows/firewall.lock.yml # .github/workflows/functional-pragmatist.lock.yml # .github/workflows/github-mcp-structural-analysis.lock.yml # .github/workflows/github-mcp-tools-report.lock.yml # .github/workflows/github-remote-mcp-auth-test.lock.yml # .github/workflows/glossary-maintainer.lock.yml # .github/workflows/go-fan.lock.yml # .github/workflows/go-logger.lock.yml # .github/workflows/go-pattern-detector.lock.yml # .github/workflows/gpclean.lock.yml # .github/workflows/grumpy-reviewer.lock.yml # .github/workflows/hippo-embed.lock.yml # .github/workflows/hourly-ci-cleaner.lock.yml # .github/workflows/instructions-janitor.lock.yml # .github/workflows/issue-arborist.lock.yml # .github/workflows/issue-monster.lock.yml # .github/workflows/issue-triage-agent.lock.yml # .github/workflows/jsweep.lock.yml # .github/workflows/layout-spec-maintainer.lock.yml # .github/workflows/lockfile-stats.lock.yml # .github/workflows/mcp-inspector.lock.yml # .github/workflows/mergefest.lock.yml # .github/workflows/metrics-collector.lock.yml # .github/workflows/notion-issue-summary.lock.yml # .github/workflows/org-health-report.lock.yml # .github/workflows/pdf-summary.lock.yml # .github/workflows/plan.lock.yml # .github/workflows/poem-bot.lock.yml # .github/workflows/pr-nitpick-reviewer.lock.yml # .github/workflows/pr-triage-agent.lock.yml # .github/workflows/prompt-clustering-analysis.lock.yml # .github/workflows/python-data-charts.lock.yml # .github/workflows/q.lock.yml # .github/workflows/refactoring-cadence.lock.yml # .github/workflows/refiner.lock.yml # .github/workflows/release.lock.yml # .github/workflows/repo-audit-analyzer.lock.yml # .github/workflows/repo-tree-map.lock.yml # .github/workflows/repository-quality-improver.lock.yml # .github/workflows/research.lock.yml # .github/workflows/schema-feature-coverage.lock.yml # .github/workflows/security-review.lock.yml # .github/workflows/slide-deck-maintainer.lock.yml # .github/workflows/smoke-agent-public-approved.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-ci.lock.yml # .github/workflows/smoke-copilot-arm.lock.yml # .github/workflows/smoke-copilot.lock.yml # .github/workflows/smoke-multi-pr.lock.yml # .github/workflows/smoke-temporary-id.lock.yml # .github/workflows/smoke-workflow-call-with-inputs.lock.yml # .github/workflows/spec-extractor.lock.yml # .github/workflows/static-analysis-report.lock.yml # .github/workflows/super-linter.lock.yml # .github/workflows/test-create-pr-error-handling.lock.yml # .github/workflows/test-quality-sentinel.lock.yml # .github/workflows/typist.lock.yml # .github/workflows/update-astro.lock.yml # .github/workflows/weekly-editors-health-check.lock.yml # .github/workflows/workflow-generator.lock.yml # .github/workflows/workflow-skill-extractor.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in 85245cd. Merged origin/main (163 lock file conflicts resolved), rebuilt the binary, and recompiled all 204 workflow lock files successfully. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot merge main and recompile |
…es-mcp-cli # Conflicts: # .github/workflows/copilot-opt.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in b71d912. Resolved 1 lock file conflict, rebuilt the binary, and recompiled all 204 workflow lock files successfully. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment. |
The
features.mcp-cliflag was a redundant gate on top oftools.mount-as-clis. This removes the feature flag and makes CLI mounting default behavior whentools.cli-proxy: trueis set. Safeoutputs and mcpscripts lose their auto-mount privilege — they now require explicitcli-proxy: truelike all other servers.Changes
pkg/constants/feature_constants.go— RemoveMCPCLIFeatureFlag("mcp-cli")pkg/workflow/mcp_cli_mount.goParsedTools.CLIProxyinstead ofisFeatureEnabled(MCPCLIFeatureFlag)alwaysCLIMountedServers— safeoutputs/mcpscripts are no longer unconditionally mounted; they follow the samecli-proxy: truepath as playwright, custom servers, etc.getMCPCLIExcludeFromAgentConfig(drops dual-access special-casing)buildCLIWorkflowDataForMountspkg/workflow/tools_types.go/tools_parser.go/ schema — RenameMountAsCLIs/mount-as-clis→CLIProxy/cli-proxy.mdfiles —mount-as-clis: true→cli-proxy: true;mcp-cli: trueremoved fromfeatures:blocks; emptyfeatures:blocks cleaned upCLIProxyfield,MCPCLIFeatureFlagreferences removedpkg/cli/codemod_mount_as_clis.go— New codemodmount-as-clis-to-cli-proxythat renamestools.mount-as-clis→tools.cli-proxyand removes the deprecatedfeatures.mcp-cliflag; registered inGetAllCodemods()and runnable viagh aw fixBefore / After