Skip to content

Fix integration tests: update domain checks from CLI flags to JSON config keys#29429

Merged
pelikhan merged 2 commits intomainfrom
copilot/fix-integration-workflow-misc-part-2
May 1, 2026
Merged

Fix integration tests: update domain checks from CLI flags to JSON config keys#29429
pelikhan merged 2 commits intomainfrom
copilot/fix-integration-workflow-misc-part-2

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 1, 2026

The AWF firewall was refactored to replace --allow-domains/--block-domains CLI flags with a structured JSON config file written via --config. Domain lists now appear as "allowDomains"/"blockDomains" JSON keys in the compiled lock file, but two integration test files still asserted on the old flag strings, causing CI failures.

Changes

  • blocked_domains_integration_test.go — Replace 4× --block-domains and 2× --allow-domains string checks with "blockDomains" / "allowDomains" JSON key checks (including the negative assertion for the no-blocked-domains case)
  • domains_protocol_integration_test.go — Replace 2× --allow-domains checks with "allowDomains" JSON key checks in TestProtocolSpecificDomainsIntegration and TestBackwardCompatibilityNoProtocol

Before → After:

// Before (checking for old CLI flag in lock YAML)
if !strings.Contains(lockYAML, "--block-domains") { ... }
if !strings.Contains(lockYAML, "--allow-domains") { ... }

// After (checking for JSON config keys embedded in lock YAML)
if !strings.Contains(lockYAML, `"blockDomains"`) { ... }
if !strings.Contains(lockYAML, `"allowDomains"`) { ... }

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh repo view --json owner,name --jq .owner.login + "/" + .name 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env ortcfg GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 3238844/b011/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env 3507-35333/test-source-field-variant-1158229901/.github/workflows GO111MODULE .cfg GOINSECURE b/gh-aw/pkg/slicrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GOMOD GOMODCACHE 64/pkg/tool/linuTest User env ortcfg GO111MODULE .cfg GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/orgs/test-owner/actions/secrets
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json cpgodebug/mcpgodebug.go 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /orgs/test-owner/actions/secrets --jq .secrets[].name -json GO111MODULE /node GOINSECURE GOMOD GOMODCACHE go /pre�� -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv xterm-color 64/pkg/tool/linux_amd64/vet /usr/bin/git ortcfg n8hJV-ZkR ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linutest@example.com /usr/bin/git 2888/001/stabilinode GO111MODULE .cfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq [.object.sha, .object.type] | @tsv --show-toplevel epo}/actions/runs/3/artifacts /usr/bin/git e GO111MODULE 64/pkg/tool/linu--show-toplevel git rev-�� --show-toplevel 64/pkg/tool/linutest@example.com /usr/bin/git -json GO111MODULE k/node_modules/.install git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v3
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv /repos/github/gh-aw/git/ref/tags/v2.0.0 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq [.object.sha, .object.type] | @tsv /tmp/gh-aw-test-runs/20260501-033915-61278/test-2407505257/.github/workflows rev-parse /usr/bin/git re GO111MODULE 64/bin/go git conf�� w.md remote.origin.url /usr/bin/git iant-1650262957/git GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v5
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv 3507-35333/test-4243581727/.github/workflows _zAe/m6K4S-499xrKjIdi_zAe 1/x64/bin/node GOINSECURE g/x/net/http/httrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com t-ha�� vaScript2116537947/001/test-simple-frontmatter.md hPW9/JwXM9fVV_p6N5EVshPW9 64/pkg/tool/linux_amd64/link -p internal/coveragrev-parse -lang=go1.25 64/pkg/tool/linux_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x^remote\..*\.gh-resolved$ /usr/bin/git 3238844/b242/_pkgit V7o_/18xeupG6XnJrev-parse ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git g9lJ/QNSRYMftluhgit -trimpath 64/pkg/tool/linu--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq [.object.sha, .object.type] | @tsv /ref/tags/v9 ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet sv se 6066708/b115/vetrev-parse /usr/bin/git git rev-�� --show-toplevel git /usr/bin/git /tmp/gh-aw-test-git git /usr/bin/git git (http block)
  • https://api.github.com/repos/actions/checkout/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv Em4H7IUTM -trimpath 1/x64/bin/node =receive log/slog -lang=go1.25 (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv /tmp/go-build3986066708/b410/console.test -importcfg ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet -s -w -buildmode=exe ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /tmp�� testing.testBinary=1 -extld=gcc /usr/bin/git -json GO111MODULE 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv xterm-color l ache/node/24.14.1/x64/bin/node -json GO111MODULE 64/bin/go git t-25�� k/gh-aw/gh-aw/.github/workflows/architecture-guardian.md s/2/artifacts /usr/bin/git -json GO111MODULE x_amd64/compile git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v8
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linuTest User /usr/bin/git vaScript21165379git -trimpath Name,createdAt,startedAt,updated--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/x64/pkg/tool/linu/home/REDACTED/work/gh-aw/gh-aw/pkg/stringutil/iderev-parse /usr/bin/git '/tmp/TestParseDgit '/tmp/TestParseDrev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq [.object.sha, .object.type] | @tsv --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm /usr/bin/git -json GO111MODULE 1/x64/bin/node git rev-�� --show-toplevel 1/x64/bin/node /usr/bin/git -json GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/actions/github-script/git/ref/tags/v9
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE iptables -w -t security 64/bin/go -nxv GOWORK 64/bin/go go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v9 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE 0GXogzJW_IN_ env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/actions/setup-go/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linutest@example.com /usr/bin/infocmp g_.a eF_9lmWUN ache/go/1.25.8/x--show-toplevel infocmp -1 xterm-color go /usr/bin/git YK2ksoSHq GO111MODULE eutil.test git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel go /usr/bin/git */*.ts' '**/*.jsgit GO111MODULE $name) { has--show-toplevel git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/.github/workflows/artifacts-summary.md s/1/artifacts ache/node/24.14.1/x64/bin/node -json GO111MODULE x_amd64/asm ache/node/24.14.1/x64/bin/node 1530�� GOMODCACHE x_amd64/asm /tmp/go-build3986066708/b462/types.test -json GO111MODULE x_amd64/compile /tmp/go-build3986066708/b462/types.test (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linux_amd64/compile /usr/bin/git LsRemoteWithRealgit LsRemoteWithRealrev-parse ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel go /usr/bin/git 964961/001 Ffi6x77fi ache/go/1.25.8/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv ons-test1033617572 remote.origin.url /usr/bin/gh l GO111MODULE 06a39f3f0d43ec78--show-toplevel gh api /repos/actions/github-script/git/ref/tags/v9 --jq om/owner/repo.git -json GO111MODULE 64/bin/go git (http block)
  • https://api.github.com/repos/actions/setup-node/git/ref/tags/v6
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv OKEN }} -trimpath /usr/bin/cut -I /tmp/go-build191rev-parse -I cut -c1 GOOS_js -D /usr/bin/git -o /tmp/go-build191rev-parse /opt/hostedtoolc--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv runs/20260501-033507-35333/test-3426706169/.github/workflows --log-level "warnings":[]}] l auto -nolocalimports ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile comm�� 6066708/b462/_pkg_.a initial commit 6066708/b462=> -json o 64/bin/go git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v6 --jq [.object.sha, .object.type] | @tsv --get l ache/node/24.14.1/x64/bin/node -json (http block)
  • https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go /usr/bin/git -json GO111MODULE x_amd64/asm git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/actions/upload-artifact/git/ref/tags/v4 --jq [.object.sha, .object.type] | @tsv -stringintconv -tests /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json GO111MODULE 64/bin/go node /tmp�� /home/REDACTED/work/gh-aw/gh-aw/.github/workflows/agent-persona-explorer.md go (http block)
  • https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv . ache/node/24.14.1/x64/bin/node odules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/git full1.txt e0b04f1a nfig/composer/veuser.name git init�� -q (http block)
    • Triggering command: /usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq [.object.sha, .object.type] | @tsv . ache/node/24.14.1/x64/bin/node k/_temp/uv-python-dir/git full1.txt e0b04f1a k/gh-aw/gh-aw/acgit commit -m 'Initial commit' git init�� -q (http block)
  • https://api.github.com/repos/github/gh-aw
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .default_branch .go git 1/x64/bin/node 650c4d51d2628e1ainfocmp --stdout es/.bin/git 1/x64/bin/node ve -q tions/setup/js/node_modules/vitest/suppress-warnings.cjs repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -exist e1130666c3d5d3d6-C bin/git tions/setup/js/nconfig (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw --jq .default_branch k/gh-aw/gh-aw/.gremote.origin.url /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs me: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } node --conditions development /opt/hostedtoolcrev-parse -o ithub/workflows -importcfg /opt/hostedtoolcache/node/24.14.-f -s -w -buildmode=exe /opt/hostedtoolcshow (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v0.1.2
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel 8n/W7nDXlF-2wrJG-extld=gcc /usr/bin/infocmp g_.a sYYP-7R33 ache/go/1.25.8/x--show-toplevel infocmp -1 xterm-color go /usr/bin/git mpiledOutput1233git GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v0.1.2 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git source-field-vargit GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel go /usr/bin/git 7/001/inlined-a.git GO111MODULE ache/go/1.25.8/x--show-toplevel git (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv k/gh-aw/gh-aw/.github/workflows/api-consumption-report.md 6066708/b447/_testmain.go /usr/bin/git remote.origin.urgit GO111MODULE 64/bin/go git rev-�� --show-toplevel go /tmp/go-build3986066708/b459/tty.test -json GO111MODULE x_amd64/compile /tmp/go-build3986066708/b459/tty.test (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv --pack_header=2,v1.0.0 (http block)
  • https://api.github.com/repos/github/gh-aw-actions/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv --show-toplevel go /usr/bin/git -json GO111MODULE 64/bin/go git rev-�� --show-toplevel go om/org2/repo2.git -json GO111MODULE x_amd64/compile git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw-actions/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv . l /opt/hostedtoolcache/node/24.14.1/x64/bin/node -json GO111MODULE (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-24 GOMOD GOMODCACHE 64/pkg/tool/linutest@example.com env g_.a GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-04-01 GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env ty-test.md GO111MODULE 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linutest@example.com (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --limit 100 --created >=2026-01-31 GOMOD GOMODCACHE 64/pkg/tool/linuremote.origin.url env ub/workflows rotocol/go-sdk@v1.5.0/internal/jsonrpc2/conn.go 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/link ortc�� sole.test 64/src/os/dir.go x_amd64/vet GOINSECURE 3238844/b013/ GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh run download 1 --dir test-logs/run-1 Y_7BzNNuM ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-dwarf=false env 841837002 Ak5qHtlUh k GOINSECURE /strconv GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu/tmp/go-build3986066708/b441/_testmain.go (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/1/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuTest User env rt GO111MODULE /home/REDACTED/work/gh-aw/gh-aw/node_modules/.bin/sh GOINSECURE GOMOD GOMODCACHE sh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name xpQFH7LFx 64/pkg/tool/linux_amd64/vet GOINSECURE ack GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1481495956 Hgqea9f-D ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 12345 --dir test-logs/run-12345 ne_constants.go 64/pkg/tool/linux_amd64/vet GOINSECURE go-sdk/internal//tmp/test-expr-627848606.js GOMODCACHE 64/pkg/tool/linux_amd64/vet env 1860598561 GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuremote.origin.url (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12345/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet env 3915-61278/test-2171266281 GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name B-Au8vNkW 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linu^remote\..*\.gh-resolved$ env 1481495956 yi2fVdpoL x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link (http block)
    • Triggering command: /usr/bin/gh gh run download 12346 --dir test-logs/run-12346 dtNyzpRaw x_amd64/link GOINSECURE v3 GOMODCACHE x_amd64/link env UHnj43LIy GO111MODULE x_amd64/vet GOINSECURE GOMOD GOMODCACHE x_amd64/vet (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/12346/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE erignore GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet env 3915-61278/test-2171266281 GO111MODULE /opt/hostedtoolcache/go/1.25.8/x64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name sNGC5r73k 64/pkg/tool/linux_amd64/link GOINSECURE pproxy GOMODCACHE 64/pkg/tool/linux_amd64/link env util.test O_2Lfc9jA ortcfg.link GOINSECURE GOMOD GOMODCACHE 6lOae4WsPt2nvzZ6origin (http block)
    • Triggering command: /usr/bin/gh gh run download 2 --dir test-logs/run-2 YfB4YDUdE ache/go/1.25.8/x64/pkg/tool/linu-nilfunc GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-trimpath env ortcfg _wTXDDAYc ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE /sys GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-goversion (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/2/artifacts --jq .artifacts[].name GO111MODULE ache/node/24.14.1/x64/bin/node GOINSECURE GOMOD GOMODCACHE go t-27�� sistency_GoAndJavaScript684218862/001/test-empty-frontmatter.md GO111MODULE e/git GOINSECURE GOMOD GOMODCACHE e/git (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name 3GMM57Ps3 64/pkg/tool/linux_amd64/compile GOINSECURE gset GOMODCACHE 64/pkg/tool/linux_amd64/compile env g_.a GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/xTest User (http block)
    • Triggering command: /usr/bin/gh gh run download 3 --dir test-logs/run-3 deRMpwyMD 64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/compile env 47/001/test-frontmatter-with-env-p GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE /exithook GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linu-dwarf=false (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/3/artifacts --jq .artifacts[].name GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com env rt GO111MODULE /home/REDACTED/work/node_modules/.bin/sh GOINSECURE GOMOD GOMODCACHE sh (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name k1Ubnk-ff 64/pkg/tool/linux_amd64/vet GOINSECURE til GOMODCACHE 64/pkg/tool/linux_amd64/vet env ijOXly7jX GO111MODULE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE s GOMODCACHE ache/go/1.25.8/xtest@example.com (http block)
    • Triggering command: /usr/bin/gh gh run download 4 --dir test-logs/run-4 J9_2Hh5RJ ache/go/1.25.8/x64/pkg/tool/linux_amd64/asm GOINSECURE chema/v6 GOMODCACHE ache/go/1.25.8/xtest@example.com env 47/001/test-complex-frontmatter--errorsas GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-nilfunc GOINSECURE 3238844/b029/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuremote (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/4/artifacts --jq .artifacts[].name GO111MODULE 7816965/b404/cli.test GOINSECURE GOMOD GOMODCACHE 7816965/b404/cli.test e=/t�� t0 GO111MODULE Name,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle m0s GOMOD (http block)
  • https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name 34i--fWCy 64/pkg/tool/linux_amd64/vet GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linux_amd64/vet env 3426706169/.github/workflows kTMme1tRE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE iment GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run download 5 --dir test-logs/run-5 fG0BeREzZ ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE chema/v6/kind GOMODCACHE ache/go/1.25.8/xTest User env 841837002/.github/workflows GO111MODULE ache/go/1.25.8/x64/pkg/tool/linu-buildmode=exe GOINSECURE /math GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuconfig (http block)
    • Triggering command: /usr/bin/gh gh api --paginate repos/{owner}/{repo}/actions/runs/5/artifacts --jq .artifacts[].name GO111MODULE ache/node/24.14.1/x64/bin/node GOINSECURE GOMOD GOMODCACHE go t-24�� sistency_GoAndJavaScript684218862/001/test-simple-frontmatter.md GO111MODULE e/git-receive-pack GOINSECURE GOMOD GOMODCACHE (http block)
  • https://api.github.com/repos/github/gh-aw/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path -json context/xcontext.go 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE x_amd64/asm env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE 64/pkg/tool/linuremote2 estl�� i/install.sh 4Gx5UXvR1 ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile (http block)
  • https://api.github.com/repos/github/gh-aw/contents/.github/workflows/shared/reporting.md
    • Triggering command: /tmp/go-build3986066708/b404/cli.test /tmp/go-build3986066708/b404/cli.test -test.testlogfile=/tmp/go-build3986066708/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true -nolocalimports -importcfg /tmp/go-build1913238844/b257/importcfg -pack env -json tions.go 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /tmp/go-build4167816965/b404/cli.test /tmp/go-build4167816965/b404/cli.test -test.testlogfile=/tmp/go-build4167816965/b404/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v0.47.4
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel 64/pkg/tool/linux_amd64/vet /usr/bin/git 3238844/b033/impgit ELPw/QEPjXdEopvSrev-parse /opt/hostedtoolc--show-toplevel git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.8/xtest@example.com /usr/bin/git 3238844/b179/impdu -trimpath .cfg git (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v0.47.4 --jq [.object.sha, .object.type] | @tsv --show-toplevel echo "golangci-lint is not installed. Run 'make remote /usr/bin/git -json GO111MODULE ache/go/1.25.8/x--show-toplevel git rev-�� --show-toplevel ache/go/1.25.8/x64/pkg/tool/linux_amd64/vet /usr/bin/git 3915-61278/test-du GO111MODULE /opt/hostedtoolc/tmp/gh-aw/aw-feature-branch.patch git (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv 3238844/b198/_pkg_.a om/segmentio/asm@v1.1.3/ascii/ascii.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env 3238844/b155/_pkg_.a 38wk/F3_s36TZU8RlNGu_38wk ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE ntio/encoding/isrev-parse GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linuorigin (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env ub/workflows GO111MODULE 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.2.3
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile _bra�� -json r/common.go x_amd64/compile GOINSECURE GOMOD bytealg/indexbyt--show-toplevel x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.2.3 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env ty-test.md GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v2.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD runtime/atomic/a/tmp/TestHashConsistency_GoAndJavaScript2116537947/001/test-empty-frontmatter.md x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv iant-2628608386/.github/workflows x86.go x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v2.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/github/gh-aw/git/ref/tags/v3.0.0
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json o x_amd64/compile GOINSECURE GOMOD GOMODCACHE nZZzdgr/Win8VWOQaRiefE3LJ-80 env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v3.0.0 --jq [.object.sha, .object.type] | @tsv -json GO111MODULE ode_modules/.bin/sh GOINSECURE GOMOD GOMODCACHE go env Gitmaster_branch2386406316/001' Gitmaster_branch2386406316/001' 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv 4080015852/001 om/segmentio/encoding@v0.5.4/ascii/equal_fold.go x_amd64/compile GOINSECURE 3238844/b011/ GOMODCACHE x_amd64/compile sRem�� 3238844/b157/_pkg_.a GO111MODULE .cfg GOINSECURE GOMOD 3238844/b011/sym--show-toplevel ache/go/1.25.8/x64/src/runtime/aorigin (http block)
    • Triggering command: /usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq [.object.sha, .object.type] | @tsv th .prettierignore GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env source-field-variant-1650262957/--detach GO111MODULE 1/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/node GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/nonexistent/repo/actions/runs/12345
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile ortc�� /ref/tags/v9 om/google/jsonschema-go@v0.4.3/jsonschema/annota--all sv GOINSECURE GOMOD GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linutest@example.com (http block)
    • Triggering command: /usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE find /usr�� -mindepth =master 7816965/b458/vet.cfg 1 -regex .*[0-9]\.[0-9] node (http block)
  • https://api.github.com/repos/owner/repo/actions/workflows
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE x_amd64/asm GOINSECURE GOMOD GOMODCACHE x_amd64/asm (http block)
    • Triggering command: /usr/bin/gh gh workflow list --json name,state,path --repo owner/repo -nolocalimports -importcfg /tmp/go-build3986066708/b435/importcfg -pack /tmp/go-build3986066708/b435/_testmain.go env -json GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile (http block)
    • Triggering command: /usr/bin/gh gh workflow list --repo owner/repo --json name,path,state ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE til GOMODCACHE ache/go/1.25.8/xremote.origin.url env Dv6-9UflV vce9/Iw7fHw9tzQV_56Gjvce9 ache/go/1.25.8/x64/pkg/tool/linu-lang=go1.25 GOINSECURE GOMOD GOMODCACHE ortcfg (http block)
  • https://api.github.com/repos/test-owner/test-repo/actions/secrets
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env h ../../../.pret.prettierignore GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go (http block)
  • https://api.github.com/repos/test/repo
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch 3507-35333/test-source-field-variant-2628608386/remote.origin.url om/segmentio/asm@v1.1.3/cpu/arm64/arm64.go ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile GOINSECURE 3238844/b036/ GOMODCACHE ache/go/1.25.8/x64/pkg/tool/linux_amd64/compile env 3238844/b151/_pkg_.a GO111MODULE d-run GOINSECURE ntio/asm/cpu/x86remote ache/go/1.25.8/x-v go (http block)
    • Triggering command: /usr/bin/gh gh api /repos/test/repo --jq .default_branch needs.build.outputs.version go /usr/bin/git -json GO111MODULE 64/bin/go git conf�� user.email test@example.com /usr/bin/git 1544600354/.githgit GO111MODULE 64/bin/go git (http block)
  • invalid.example.invalid
    • Triggering command: /usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https origin https://invalid.example.invalid/nonexistent-repo.git e/git init�� ndor/bin/git git ode_modules/.bin/git =receive test@example.com--git-dir=/tmp/bare-incremental-VfRQWK /git (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

…n checks

The AWF firewall was refactored to embed domain config via --config JSON
file instead of --allow-domains/--block-domains CLI flags. Update the
integration tests in blocked_domains_integration_test.go and
domains_protocol_integration_test.go to check for "allowDomains" and
"blockDomains" JSON keys instead of the old CLI flag strings.

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/120fec7d-4dbb-4d59-8525-c2bf7c00017f

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Integration: Workflow Misc Part 2 Fix integration tests: update domain checks from CLI flags to JSON config keys May 1, 2026
Copilot AI requested a review from pelikhan May 1, 2026 03:41
@pelikhan pelikhan marked this pull request as ready for review May 1, 2026 03:42
Copilot AI review requested due to automatic review settings May 1, 2026 03:42
@pelikhan pelikhan merged commit b974261 into main May 1, 2026
19 checks passed
@pelikhan pelikhan deleted the copilot/fix-integration-workflow-misc-part-2 branch May 1, 2026 03:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates workflow integration tests to assert on the new AWF JSON config keys (allowDomains/blockDomains) embedded in the compiled lock file, instead of the removed legacy CLI flags (--allow-domains/--block-domains).

Changes:

  • Update domains_protocol_integration_test.go to check for "allowDomains" in the compiled lock content.
  • Update blocked_domains_integration_test.go to check for "blockDomains" / "allowDomains" and update the “no blocked domains” negative assertion accordingly.
Show a summary per file
File Description
pkg/workflow/domains_protocol_integration_test.go Replaces legacy --allow-domains assertions with "allowDomains" JSON key assertions.
pkg/workflow/blocked_domains_integration_test.go Replaces legacy --block-domains/--allow-domains assertions with "blockDomains"/"allowDomains" JSON key assertions, including the negative check.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment on lines +139 to +142
// If checking AWF args, verify allowDomains key is present in the config JSON
if tt.checkAWFArgs {
if !strings.Contains(lockYAML, "--allow-domains") {
t.Error("Expected --allow-domains flag in compiled workflow")
if !strings.Contains(lockYAML, `"allowDomains"`) {
t.Error("Expected 'allowDomains' key in config JSON of compiled workflow")
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment still refers to checking “AWF args”, but the assertion is now validating the presence of a JSON config key in the compiled lock content. Consider rewording this comment (and the related expectedDomains field comment earlier in the file) to avoid implying the legacy --allow-domains CLI flags are being checked here.

Copilot uses AI. Check for mistakes.
Comment on lines +211 to 214
// Verify blockDomains key is NOT present in the config JSON
if strings.Contains(lockYAML, `"blockDomains"`) {
t.Error("Compiled workflow should NOT contain 'blockDomains' key in config JSON when no domains are blocked")
}
Copy link

Copilot AI May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test now asserts that the compiled lock file does not contain the blockDomains JSON key, but the subtest name still says “does not have block-domains flag”. Renaming the t.Run(...) description to match the new JSON-config-based behavior will make failures easier to interpret.

Copilot uses AI. Check for mistakes.
@github-actions github-actions Bot mentioned this pull request May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

🧪 Test Quality Sentinel Report

Test Quality Score: 95/100

Excellent test quality

Metric Value
New/modified tests analyzed 4
✅ Design tests (behavioral contracts) 4 (100%)
⚠️ Implementation tests (low value) 0 (0%)
Tests with error/edge cases 4 (100%)
Duplicate test clusters 0
Test inflation detected No
🚨 Coding-guideline violations None

Test Classification Details

Test File Classification Issues Detected
TestBlockedDomainsIntegration (3 subtests) pkg/workflow/blocked_domains_integration_test.go ✅ Design None
TestProtocolSpecificDomainsIntegration (3 table cases) pkg/workflow/domains_protocol_integration_test.go ✅ Design None
TestProtocolSpecificDomainsValidationIntegration (3 table cases) pkg/workflow/domains_protocol_integration_test.go ✅ Design None
TestBackwardCompatibilityNoProtocol pkg/workflow/domains_protocol_integration_test.go ✅ Design None

Analysis

This PR updates 2 existing integration test files (27 additions, 27 deletions — net zero) to fix assertion strings from CLI flag checks (--block-domains, --allow-domains) to JSON config key checks ("blockDomains", "allowDomains"). This reflects the actual compiled output format of the workflow compiler.

All tests are behavioral contract tests: they compile real workflows through the actual compiler and assert that the .lock.yml output contains the expected configuration keys and domain values. No mocks are used.

Error/edge case coverage is strong:

  • TestBlockedDomainsIntegration includes a negative sub-test verifying that blockDomains is absent when no domains are blocked
  • TestProtocolSpecificDomainsValidationIntegration covers invalid protocols ((redacted) ws://) with wantErr: true` table rows
  • TestBackwardCompatibilityNoProtocol verifies legacy domain format still works

Build tags: Both files correctly begin with //go:build integration

Minor observation (not flagged): Some assertions in TestBlockedDomainsIntegration use t.Error("message") which is fine — descriptive string messages are present. The small score deduction (5 pts) is for a few assertions that could be slightly more context-rich (e.g., including the actual lockYAML excerpt on failure), but this is a minor style note, not a guideline violation.


Language Support

Tests analyzed:

  • 🐹 Go (*_test.go): 4 tests — integration (//go:build integration)
  • 🟨 JavaScript (*.test.cjs, *.test.js): 0 tests

Verdict

Check passed. 0% of new tests are implementation tests (threshold: 30%). All modified tests verify behavioral contracts of the workflow compiler, and the changes correctly update assertions to reflect the current output format.


📖 Understanding Test Classifications

Design Tests (High Value) verify what the system does:

  • Assert on observable outputs, return values, or state changes
  • Cover error paths and boundary conditions
  • Would catch a behavioral regression if deleted
  • Remain valid even after internal refactoring

Implementation Tests (Low Value) verify how the system does it:

  • Assert on internal function calls (mocking internals)
  • Only test the happy path with typical inputs
  • Break during legitimate refactoring even when behavior is correct
  • Give false assurance: they pass even when the system is wrong

Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.

References: §25201170274

🧪 Test quality analysis by Test Quality Sentinel · ● 622.9K ·

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Test Quality Sentinel: 95/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). All 4 modified integration tests verify behavioral contracts of the workflow compiler with full error/edge case coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants