[code-simplifier] Flatten nested if in sandbox strict-mode validation

[github-actions]

This PR simplifies recently modified code to improve clarity, consistency, and maintainability while preserving all functionality.

Files Simplified

• pkg/workflow/strict_mode_sandbox_validation.go - Flatten double-nested if into a single combined condition

Improvements Made

Reduced Nesting: Combined if !agent.Disabled { if !isSupportedSandboxType(...) { ... } } into a single if !agent.Disabled && !isSupportedSandboxType(...) { ... }. Reduces indentation and cognitive load with no behavior change.

Changes Based On

Recent changes from #29663 - fix: default sandbox agent type to AWF when not explicit; reject empty type in strict mode

Testing

• ✅ TestValidateStrictSandboxCustomization passes
• ✅ make fmt clean
• ✅ No functional changes — behavior is identical

---

Automated by Code Simplifier Agent - analyzing code from the last 24 hours

Note

🔒 Integrity filter blocked 1 item

The following item was blocked because it doesn't meet the GitHub integrity level.

• fix(tests): update TestAPITargetDomains tests to check AWF JSON config instead of CLI flags #29646 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Code Simplifier · ● 1.1M · ◷

• expires on May 3, 2026, 4:27 AM UTC

[Copilot]

Pull request overview

This PR refactors strict-mode sandbox validation by flattening a nested conditional into a single combined condition, with the stated goal of improving readability without changing behavior.

Changes:

• Combine the agent.Disabled guard and sandbox type validation into one if statement.
• Preserve the existing strict-mode error path for ambiguous sandbox.agent configurations.
• Leave the surrounding strict-mode validation logic unchanged.

Show a summary per file

File	Description
pkg/workflow/strict_mode_sandbox_validation.go	Simplifies the strict-mode sandbox.agent validation branch by collapsing nested conditionals.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0