Fix SC2086 shellcheck warnings in super-linter workflow#3645
Merged
Conversation
- Add double quotes around $GITHUB_OUTPUT variable references - Fixes 3 SC2086 warnings about missing quotes to prevent globbing - Verified with actionlint that warnings are resolved - All unit tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing quotes in super-linter workflow
Fix SC2086 shellcheck warnings in super-linter workflow
Nov 11, 2025
pelikhan
approved these changes
Nov 11, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses SC2086 shellcheck warnings by adding proper double quotes around $GITHUB_OUTPUT variable references in the super-linter workflow. The fix prevents potential issues with globbing and word splitting when the variable is expanded, aligning with shell scripting best practices and the project's security guidelines.
Key Changes:
- Added double quotes around 3 instances of
$GITHUB_OUTPUTvariable references in the "Check for linting issues" step - Applied the same fix to both the source workflow file (.md) and the compiled lock file (.lock.yml)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/super-linter.md |
Added quotes around $GITHUB_OUTPUT on lines 53, 55, and 58 to prevent globbing and word splitting |
.github/workflows/super-linter.lock.yml |
Applied identical quoting fixes to the compiled workflow on lines 4544, 4546, and 4549 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three unquoted
$GITHUB_OUTPUTvariable references in the super-linter workflow triggered SC2086 warnings about missing quotes to prevent globbing and word splitting.Changes
$GITHUB_OUTPUTin the "Check for linting issues" step (3 instances)Fixes #3554
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.