Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/agent-cook.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-add-issue-comment.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-add-issue-labels.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-command.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-create-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-create-pull-request.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-mcp.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-push-to-branch.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-claude-update-issue.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-codex-command.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .github/workflows/test-proxy.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/workflow/claude_settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ func (g *ClaudeSettingsGenerator) GenerateSettingsJSON() string {
func (g *ClaudeSettingsGenerator) GenerateSettingsWorkflowStep() GitHubActionStep {
settingsJSON := g.GenerateSettingsJSON()

runContent := fmt.Sprintf(`cat > .claude/settings.json << 'EOF'
runContent := fmt.Sprintf(`mkdir -p .claude
cat > .claude/settings.json << 'EOF'
%s
EOF`, settingsJSON)

Expand Down
12 changes: 12 additions & 0 deletions pkg/workflow/claude_settings_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,23 @@ func TestClaudeSettingsWorkflowGeneration(t *testing.T) {
t.Error("Step should use multi-line run format")
}

// Check directory creation command
if !strings.Contains(stepStr, "mkdir -p .claude") {
t.Error("Step should create .claude directory before creating settings file")
}

// Check file creation
if !strings.Contains(stepStr, "cat > .claude/settings.json") {
t.Error("Step should create .claude/settings.json file")
}

// Verify the order - mkdir should come before cat
mkdirIndex := strings.Index(stepStr, "mkdir -p .claude")
catIndex := strings.Index(stepStr, "cat > .claude/settings.json")
if mkdirIndex == -1 || catIndex == -1 || mkdirIndex > catIndex {
t.Error("Directory creation (mkdir) should come before file creation (cat)")
}

// Check heredoc usage
if !strings.Contains(stepStr, "EOF") {
t.Error("Step should use heredoc for JSON content")
Expand Down