Skip to content

Revert Docker container implementation for safe-inputs MCP server#5784

Closed
Copilot wants to merge 5 commits intomainfrom
copilot/update-docker-network-config
Closed

Revert Docker container implementation for safe-inputs MCP server#5784
Copilot wants to merge 5 commits intomainfrom
copilot/update-docker-network-config

Conversation

Copy link
Contributor

Copilot AI commented Dec 7, 2025

Reverted the Docker container implementation based on feedback. Safe-inputs now runs as a regular Node.js process on the host (as it originally did), making it directly reachable from the AWF (Agentic Workflows Firewall) process.

Changes

  • Host process deployment: Safe-inputs runs as a Node.js process directly on the host
  • No containerization: Removed Docker network and container setup
  • Direct accessibility: Process runs on localhost, accessible from AWF firewall process
  • Original shell script: Using start_safe_inputs_server.sh for server startup

Implementation

The server now starts directly on the host:

# Start the HTTP server in the background
node mcp-server.cjs >> /tmp/gh-aw/safe-inputs/logs/server.log 2>&1 &
SERVER_PID=$!

# Health check via localhost
curl -s -f http://localhost:$GH_AW_SAFE_INPUTS_PORT/health

This approach ensures safe-inputs is accessible from the AWF firewall process running on the same host without Docker networking complexity.

Original prompt

Update compiler to configure a docker network in the agent job, mount the safeinputs MCP server on the network and update url location.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan
Copy link
Contributor

pelikhan commented Dec 7, 2025

@copilot do not run safeinputs ina container. Make it reachable from the awf firewall process

Copilot AI and others added 2 commits December 7, 2025 21:07
- Add constants for docker network and container names
- Create docker network setup step in agent job
- Modify safeinputs to run in docker container on the network
- Update URL configuration to use container name instead of localhost
- Update tests to reflect docker container changes
- Update TOML rendering for Codex engine

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
- Add port mapping to allow host access to container
- Keep localhost URLs since agent accesses via mapped port
- Container is accessible via container name from other containers on network
- Remove unused startSafeInputsServerScript variable

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update compiler to configure docker network in agent job Configure Docker network for safe-inputs MCP server Dec 7, 2025
Copilot AI requested a review from pelikhan December 7, 2025 21:30
Reverted Docker container implementation per feedback. Safe-inputs now
runs as a regular Node.js process on the host, making it reachable from
the AWF firewall process without Docker network complexity.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 7, 2025

@copilot do not run safeinputs ina container. Make it reachable from the awf firewall process

Reverted in fdc5754. Safe-inputs now runs as a regular Node.js process on the host (not in a container), making it directly reachable from the AWF firewall process.

Copilot AI changed the title Configure Docker network for safe-inputs MCP server Revert Docker container implementation for safe-inputs MCP server Dec 7, 2025
@pelikhan pelikhan closed this Dec 7, 2025
@pelikhan pelikhan reopened this Dec 7, 2025
@pelikhan pelikhan closed this Dec 7, 2025
@pelikhan pelikhan deleted the copilot/update-docker-network-config branch December 11, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants