[WIP] Fix environment variable expansion for safeinputs MCP server#5801
Closed
[WIP] Fix environment variable expansion for safeinputs MCP server#5801
Conversation
…rver configuration Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
@copilot look how it is done for github mcp server "remote" mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Fix Environment Variable Expansion in Safe-Inputs MCP Server Configuration
The generated MCP configuration for the safeinputs server using Copilot contains unexpanded environment variables (
${GH_AW_SAFE_INPUTS_PORT}instead of the actual port value), causing connection failures.Root Cause
When the MCP config JSON file is created with heredoc (
cat > file << EOF), environment variable placeholders like\${GH_AW_SAFE_INPUTS_PORT}are written literally. JSON doesn't expand shell variables, so when Copilot reads the config, it sees the literal string${GH_AW_SAFE_INPUTS_PORT}instead of the actual port value.Solution
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.