Skip to content

Fix test failures: update expected domains and file lists#5814

Merged
pelikhan merged 4 commits intomainfrom
copilot/format-lint-fix-tests-another-one
Dec 8, 2025
Merged

Fix test failures: update expected domains and file lists#5814
pelikhan merged 4 commits intomainfrom
copilot/format-lint-fix-tests-another-one

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

Two unit tests were failing due to outdated expectations, and a TypeScript type cast was malformed.

Test Fixes

  • TestCopilotDefaultDomains: Added host.docker.internal to expected domains list (now 7 domains total)
  • TestWriteSafeInputsFiles: Removed non-existent mcp_server.cjs from expected files (actual entry point is mcp-server.cjs with hyphen)

TypeScript Fix

Fixed JSDoc type cast syntax in mcp_server_core.cjs:

// Before: TypeScript error TS18046
const err = /** @type {any} */ error;

// After: Parentheses required for proper cast
const err = /** @type {any} */ (error);

Workflow Updates

  • Repositioned cache-memory artifact upload in spec-kit-execute workflow with if: always() condition
  • Updated action version comments in release workflow

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login it/ref/tags/v5 GO111MODULE g_.a GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/x64/pkg/tool/linu--engine env -python.git -python.git /opt/hostedtoolcache/go/1.25.0/x64/bin/go by/3827db73872cenode GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login d-artifact.git GO111MODULE ache/go/1.25.0/x64/pkg/tool/linu--systemd-cgroup GOINSECURE GOMOD -d/gh-aw ache/go/1.25.0/x--jq env it/ref/tags/v5 -d/gh-aw 1549095/b355=> GOINSECURE GOMOD GOMODCACHE go (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login /ref/tags/v8 GO111MODULE 4b1fd487e0d8da8d7f0cd113e0fd8c9999f/log.json GOINSECURE GOMOD GOMODCACHE 1/x64/bin/npm env -json om/some-owner/some-repo (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Format, lint, fix tests


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 3 commits December 8, 2025 04:16
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…iles

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Format, lint, and fix tests in the codebase Fix test failures: update expected domains and file lists Dec 8, 2025
Copilot AI requested a review from pelikhan December 8, 2025 04:39
@pelikhan pelikhan marked this pull request as ready for review December 8, 2025 04:42
@pelikhan pelikhan merged commit 1f98c7b into main Dec 8, 2025
5 checks passed
@pelikhan pelikhan deleted the copilot/format-lint-fix-tests-another-one branch December 8, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants