Skip to content

[ca] Fix code formatting alignment in argument syntax test#7307

Merged
pelikhan merged 1 commit intomainfrom
ci-cleaner-env-fix-1766430582-c6848516566dd010
Dec 22, 2025
Merged

[ca] Fix code formatting alignment in argument syntax test#7307
pelikhan merged 1 commit intomainfrom
ci-cleaner-env-fix-1766430582-c6848516566dd010

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

This PR applies Go formatting fixes to address code alignment issues discovered during automated CI cleanup (hourly-ci-cleaner workflow run #283).

Changes Made

Code Formatting

  • Go formatting: Fixed whitespace alignment in cmd/gh-aw/argument_syntax_test.go
    • Aligned map values in validPatterns slice
    • Aligned map values in conventions map
  • JavaScript formatting: All .cjs files already properly formatted (verified with prettier)
  • JSON formatting: All JSON files already properly formatted

Environment Limitations Encountered

During this CI cleanup run, I encountered severe network restrictions that prevented full validation:

Network Access Issues

  • Go module proxy: Access to proxy.golang.org is Forbidden
  • Direct Go module downloads: Access to golang.org/x/* packages blocked
  • npm installation: System npm is broken (Cannot find module '../lib/cli.js')

These restrictions prevented:

  • Running make lint (golangci-lint requires downloading dependencies)
  • Running make test or make test-unit (requires Go module dependencies)
  • Running make recompile (requires building the gh-aw binary)

Workarounds Applied

  • Used npx prettier directly instead of npm run format to format JavaScript files
  • Used go fmt directly instead of make fmt-go to format Go code
  • Set GOPROXY=direct to attempt direct downloads (still blocked by network restrictions)

Validation Status

Check Status Notes
Go formatting Applied via go fmt ./...
JavaScript formatting Verified with npx prettier - all files unchanged
JSON formatting Verified with npx prettier - all files unchanged
Linting ⚠️ Blocked - Cannot download dependencies
Tests ⚠️ Blocked - Cannot compile due to missing dependencies
Workflow recompilation ⚠️ Blocked - Cannot build binary

Recommendations

The hourly-ci-cleaner workflow needs environment improvements to function properly:

  1. Pre-install Go dependencies - Run go mod download before the agent step
  2. Fix npm installation - Ensure system npm is functional or use npx consistently
  3. Configure network access - Allow access to Go module proxy or vendor dependencies
  4. Add dependency caching - Use actions/setup-go with cache: true (already configured but may need separate download step)

Related

Impact

This PR contains only formatting fixes that were possible to apply given the environment constraints. The actual CI failure root cause could not be investigated due to the inability to run tests or linters.

AI generated by Hourly CI Cleaner

- Fix whitespace alignment in argument_syntax_test.go
- Applied go fmt to ensure consistent formatting
@pelikhan pelikhan marked this pull request as ready for review December 22, 2025 19:28
@pelikhan pelikhan merged commit 1e08c04 into main Dec 22, 2025
4 checks passed
@pelikhan pelikhan deleted the ci-cleaner-env-fix-1766430582-c6848516566dd010 branch December 22, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants