[ca] Fix npm availability check in dependabot integration test#7398
Merged
[ca] Fix npm availability check in dependabot integration test#7398
Conversation
The test was checking if npm exists but not if it's functional. This caused the test to fail when npm exists but is broken. Now the test checks if npm can actually execute before running, properly skipping when npm is not functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed CI test failure in
pkg/cli/compile_dependabot_test.gocaused by broken npm installation in the CI environment.Problem
The hourly CI cleaner workflow (run #304) failed because the
TestCompileDependabotIntegrationtest was failing. The test was checking if npm exists usingexec.LookPath("npm"), but this only verifies that the npm binary is present - not that it's functional.In the CI environment, npm was found at
/usr/local/bin/npmbut was broken with this error:This caused the test to run and then fail when trying to generate
package-lock.json, instead of being properly skipped.Solution
Enhanced the npm availability check to not only verify npm exists, but also test if it can actually execute by running
npm --version. If npm is not functional, the test is now properly skipped with a clear message:Testing
go fmt)golangci-lint)CI Run Context
Changes
pkg/cli/compile_dependabot_test.goto check npm functionality before running the testThis fix ensures that the test behaves correctly in environments where npm may be present but not functional.