Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
- Add mutual exclusion constraints for MCP gateway command/container - Add if/then for entrypointArgs requiring container - Add $comment fields explaining relationship validation - Document strict mode dependencies (validated in Go code) - Update TestSandboxConfigWithMCPGateway to include required container - Rebuild binary with updated embedded schema Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor relationship prose to use dependencies keyword
Migrate MCP relationship prose to JSON Schema constraints with $comment documentation
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field relationship requirements were documented only in prose within
descriptionfields, preventing schema validators from automatically enforcing constraints. This migrates key MCP relationships to JSON Schema's standard constraint keywords while documenting complex validation logic.Changes
Schema Constraints Added
sandbox.mcp): Enforces mutual exclusion betweencommandandcontainerusinganyOf+not.allOfsandbox.mcp): Conditional requirement thatentrypointArgsrequirescontainerusingif/then$commentdocumenting existing constraint patternsDocumentation via $comment
Added 10
$commentfields explaining:pkg/workflow/strict_mode_validation.go)Test Alignment
TestSandboxConfigWithMCPGatewayto include requiredcontainerfield per schema examplesExample
Before (prose only):
{ "command": { "type": "string", "description": "Custom command (mutually exclusive with 'container')" } }After (enforced + documented):
{ "command": { "type": "string", "$comment": "Mutually exclusive with 'container' - only one execution mode can be specified.", "description": "Custom command to execute the MCP gateway" }, "anyOf": [{"required": ["command"]}, {"required": ["container"]}], "not": {"allOf": [{"required": ["command"]}, {"required": ["container"]}]} }Schema validators now automatically catch relationship violations. Binary rebuilt with
make buildto embed updated schema.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.