Merged
Conversation
- Replace || with ?? (nullish coalescing) for better empty string handling - Remove unnecessary explanatory comments - Remove redundant return statement in catch block - Reduce code from 64 to 57 lines (11% reduction) This file already has comprehensive test coverage with 14 test cases.
pelikhan
approved these changes
Dec 29, 2025
This was referenced Dec 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned and modernized
check_skip_if_match.cjsfollowing JavaScript unbloat best practices.Changes Made
Code Improvements:
||with??(nullish coalescing) formaxMatchesStrdefault value - better handles empty stringsreturnstatement in catch block (function already ends there)Testing:
Execution Context:
core.info(),core.warning(),core.setFailed(),core.setOutput()github.rest.search.issuesAndPullRequests()Files Changed
actions/setup/js/check_skip_if_match.cjs- Cleaned and modernizedImpact