Skip to content

[security-fix] Fix unhandled error in schedule parser hash computation (Alert #393) #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Dec 30, 2025
Merged

[security-fix] Fix unhandled error in schedule parser hash computation (Alert #393) #8149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/parser/schedule_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,12 @@ func IsFuzzyCron(cron string) bool {
// using FNV-1a hash algorithm, which is stable across platforms and Go versions.
func stableHash(s string, modulo int) int {
h := fnv.New32a()
h.Write([]byte(s))
// hash.Hash.Write never returns an error in practice, but check to satisfy gosec G104
if _, err := h.Write([]byte(s)); err != nil {
// Return 0 (safe fallback) if write somehow fails
scheduleLog.Printf("Warning: hash write failed: %v", err)
return 0
}
return int(h.Sum32() % uint32(modulo))
}

Expand Down