Fix engine.version to accept numeric types per schema#8231
Merged
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix engine.version to accept numeric types
Fix engine.version to accept numeric types per schema
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema defines
engine.versionas"type": ["string", "number"]with examples[20, 3.11], but the code only accepted strings, causing numeric versions to be silently ignored.Changes
pkg/workflow/engine.go: Replace string-only type check with type switch handlingstring,int/int64/uint64, andfloat64pkg/workflow/engine_config_test.go: Add test cases for integer (20) and float (3.11) versionsImplementation
Applied the existing
max-turnspattern (lines 81-87) to theversionfield:Users can now use numeric versions as documented:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login en.git -trimpath /usr/bin/git -p github.com/githucommit l/linux_amd64/co-m git rev-�� --show-toplevel(http block)/usr/bin/gh gh api user --jq .login _.a om/github/gitignore.git /home/REDACTED/go/pkg/mod/golang.ojson -t security ache/node/24.12.--show-toplevel /home/REDACTED/go/pkg/mod/golang.o/run/containerd/io.containerd.runtime.v2.task/moby/56eb414411f4c020612e6a6e402d8b58fa933d073484475aa4650db629696795 -o .git -trimpath /usr/bin/gh -p main -lang=go1.25 gh(http block)/usr/bin/gh gh api user --jq .login pload-artifact/git/ref/tags/v5 -trimpath /usr/bin/git -p main -lang=go1.25 git -C 2515-12899/test-purge-campaign-711299749 config(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.