Fix GitHub MCP version field to accept numeric types#8232
Merged
Conversation
- Updated pkg/parser/mcp.go to handle numeric version types (int, int64, uint64, float64) - Updated pkg/workflow/mcp_servers.go getGitHubDockerImageVersion() to handle numeric types - Added test cases for integer and float versions in mcp_test.go - Added test cases for numeric versions in version_field_test.go - All tests pass successfully - Manual testing confirms integer (20) and float (3.11) versions work correctly Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MCP version field to accept numeric types
Fix GitHub MCP version field to accept numeric types
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema advertises
tools.github.versionas"type": ["string", "number"]with examples like20and3.11, but numeric versions were silently ignored due to string-only type checks in two code paths.Changes
pkg/parser/mcp.go: Extended version parsing to handleint,int64,uint64, andfloat64typespkg/workflow/mcp_servers.go: UpdatedgetGitHubDockerImageVersion()with same type handlingType Handling
YAML numeric values are parsed as
uint64(positive integers) orfloat64by goccy/go-yaml, now correctly converted to Docker image tags.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.