Add debug logging and extract glob pattern helper module for repo-memory validation by Copilot · Pull Request #8242 · github/gh-aw

Copilot · 2025-12-31T02:23:08Z

The push_repo_memory job failed with "File does not match allowed patterns: history.jsonl" despite the glob filter ["*.json", "*.jsonl", "*.csv", "*.md"] being configured. Pattern matching logic is correct (*.jsonl → ^[^/]*\.jsonl$ matches history.jsonl), suggesting the failure stems from environment variable propagation, path formatting, or timing issues.

Changes

Environment diagnostics

Log FILE_GLOB_FILTER value, length, and pattern count at startup
Log all relevant env vars (MEMORY_ID, MAX_FILE_SIZE, MAX_FILE_COUNT)

Pattern matching visibility

Debug-level logs showing per-file pattern matching with compiled regexes
Enhanced error messages displaying each pattern's regex and match result
File scan summary listing discovered files and sizes

Code refactoring

Created separate glob_pattern_helpers.cjs module with three exported functions:
- globPatternToRegex(pattern): Convert glob pattern to RegExp
- parseGlobPatterns(fileGlobFilter): Parse space-separated glob patterns
- matchesGlobPattern(filePath, fileGlobFilter): Check if file matches any pattern
Added comprehensive JSDoc documentation with examples
Updated push_repo_memory.cjs to import from the helper module
Module is automatically copied by setup.sh (copies all .cjs files)

Test coverage

Added 5 test cases for debug logging behavior
Added 37 comprehensive test cases in glob_pattern_helpers.test.cjs:
- Basic pattern matching (exact filenames, *, **)
- Special character escaping (dots, backslashes)
- Real-world patterns (*.jsonl, metrics/**, campaign-specific patterns)
- Edge cases (empty patterns, complex nested patterns, case sensitivity)
- Security tests (ReDoS prevention, proper escaping)
- Helper function tests (parseGlobPatterns, matchesGlobPattern)
- Integration tests with push_repo_memory use cases
All 87 tests passing (50 push_repo_memory + 37 glob_pattern_helpers) ✓
Validated root-level file matching (daily-code-metrics scenario)
Verified error message formatting includes actionable details

Example output

When a file fails validation, the error now shows:

File does not match allowed patterns: history.jsonl
Allowed patterns: *.json *.jsonl *.csv *.md
Pattern test results:
  *.json -> regex: ^[^/]*\.json$ -> NO MATCH
  *.jsonl -> regex: ^[^/]*\.jsonl$ -> MATCH

Debug logs for each file:

Testing file: history.jsonl
  Pattern 2: "*.jsonl" -> ^[^/]*\.jsonl$ -> ✓ MATCH

Next workflow run will immediately reveal the root cause.

Original prompt

Reference: https://github.com/githubnext/gh-aw/actions/runs/20610342090/job/59193817350#step:7:1

Investigate why the file history.jsonl did not match the glob filter. Add tests and logging.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

- Add debug logging to show file glob filter configuration - Add detailed pattern matching logs for each file - Add enhanced error messages with regex patterns and test results - Add new tests for debug logging functionality - Add tests for root-level file matching (daily-code-metrics use case) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2025-12-31T02:33:16Z

actions/setup/js/push_repo_memory.cjs

@@ -283,9 +292,26 @@ async function main() {
              return new RegExp(`^${regexPattern}$`);


@copilot move pattern to regex helper to separate function and add tests to validate behavior

Done in commit 1e498c4. Extracted globPatternToRegex() as a standalone function with full JSDoc documentation and added 20 comprehensive test cases covering:

Basic patterns (exact, *, **)

Special character escaping

Real-world scenarios (*.jsonl, metrics/**, campaigns)

Edge cases (empty, complex nested patterns)

Regex output validation

All 50 tests passing ✓

- Log FILE_GLOB_FILTER environment variable value and length - Log MEMORY_ID, MAX_FILE_SIZE, MAX_FILE_COUNT for debugging - Add summary of files found after scanning - Show first 10 files or all files if <= 10 found Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

- Move glob-to-regex conversion logic to standalone function - Export globPatternToRegex for testing and reusability - Add 20 new test cases covering: - Basic pattern matching (exact, *, **) - Special character escaping (dots, backslashes) - Real-world patterns (*.jsonl, metrics/**, campaigns) - Edge cases (empty, wildcards only, complex nested) - Regex output format validation - All 50 tests passing Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2025-12-31T03:04:41Z

actions/setup/js/push_repo_memory.cjs

+ * - . is escaped to match literal dots
+ * - \ is escaped properly
+ */
+function globPatternToRegex(pattern) {


@copilot move to separate file, add more tests, update setup.sh

Done in commit 9be23c5. Created separate glob_pattern_helpers.cjs module with:

3 exported functions: globPatternToRegex(), parseGlobPatterns(), matchesGlobPattern()

37 comprehensive tests covering patterns, escaping, edge cases, security, and integration

Updated push_repo_memory.cjs to import from the helper

All 87 tests passing ✓

Setup.sh automatically copies all .cjs files, so the new module will be available at runtime without changes to setup.sh.

- Created glob_pattern_helpers.cjs with 3 exported functions: - globPatternToRegex: Convert glob pattern to RegExp - parseGlobPatterns: Parse space-separated patterns - matchesGlobPattern: Check if file matches any pattern - Added 37 comprehensive tests in glob_pattern_helpers.test.cjs: - Basic pattern matching (exact, *, **) - Special character escaping - Real-world patterns (daily-code-metrics, campaigns) - Edge cases and security tests - Integration tests with push_repo_memory - Updated push_repo_memory.cjs to import from helper module - Updated push_repo_memory.test.cjs to import from helper module - All 87 tests passing (50 push_repo_memory + 37 glob_pattern_helpers) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2025-12-31T03:29:36Z

@copilot Lint js

Copilot · 2025-12-31T03:32:48Z

@copilot Lint js

All JavaScript files pass linting ✓

make fmt-cjs: All files properly formatted (no changes needed)
make lint-cjs: All files pass Prettier checks
All 87 tests passing (50 push_repo_memory + 37 glob_pattern_helpers)

Initial plan

0c9c6dc

Copilot AI assigned Copilot and pelikhan Dec 31, 2025

Copilot started work on behalf of pelikhan December 31, 2025 02:23 View session

pelikhan reviewed Dec 31, 2025

View reviewed changes

Copilot AI changed the title ~~[WIP] Investigate file history.jsonl glob filter mismatch~~ Add debug logging for repo-memory glob filter validation failures Dec 31, 2025

Copilot AI requested a review from pelikhan December 31, 2025 02:43

Copilot finished work on behalf of pelikhan December 31, 2025 02:43

Copilot started work on behalf of pelikhan December 31, 2025 02:43 View session

Copilot AI changed the title ~~Add debug logging for repo-memory glob filter validation failures~~ Add debug logging and extract glob pattern helper for repo-memory validation Dec 31, 2025

Copilot finished work on behalf of pelikhan December 31, 2025 02:54

pelikhan reviewed Dec 31, 2025

View reviewed changes

Copilot started work on behalf of pelikhan December 31, 2025 03:05 View session

Copilot AI changed the title ~~Add debug logging and extract glob pattern helper for repo-memory validation~~ Add debug logging and extract glob pattern helper module for repo-memory validation Dec 31, 2025

Copilot AI requested a review from pelikhan December 31, 2025 03:14

Copilot finished work on behalf of pelikhan December 31, 2025 03:14

pelikhan marked this pull request as ready for review December 31, 2025 03:27

Copilot started work on behalf of pelikhan December 31, 2025 03:30 View session

Copilot finished work on behalf of pelikhan December 31, 2025 03:33

pelikhan merged commit d9ae817 into main Dec 31, 2025
97 of 99 checks passed

pelikhan deleted the copilot/investigate-file-history-glob-issue branch December 31, 2025 03:34

This was referenced Dec 31, 2025

Mount MCP config directory in AWF container for Copilot workflows #8249

Merged

[team-status] Daily Team Status: December 31, 2025 - Productive Code Quality Day! 🌟 #8273

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add debug logging and extract glob pattern helper module for repo-memory validation#8242

Add debug logging and extract glob pattern helper module for repo-memory validation#8242
pelikhan merged 5 commits intomainfrom
copilot/investigate-file-history-glob-issue

Copilot AI commented Dec 31, 2025 •

edited

Loading

Uh oh!

pelikhan Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

pelikhan Dec 31, 2025

Uh oh!

Copilot AI Dec 31, 2025

Uh oh!

pelikhan commented Dec 31, 2025

Uh oh!

Copilot AI commented Dec 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -283,9 +292,26 @@ async function main() {
		return new RegExp(`^${regexPattern}$`);

Conversation

Copilot AI commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example output

Uh oh!

pelikhan Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Dec 31, 2025

Uh oh!

Copilot AI commented Dec 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 31, 2025 •

edited

Loading