Fix tests: Remove github-token from individual safe output type configurations#8254
Merged
Fix tests: Remove github-token from individual safe output type configurations#8254
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tests by removing GitHub-token from safe output types
Fix tests: Remove github-token from individual safe output type configurations
Dec 31, 2025
pelikhan
approved these changes
Dec 31, 2025
This was referenced Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were failing because they expected
github-tokento be configurable at individual safe output type level (e.g.,create-issue.github-token), but the schema correctly only allows it at workflow and global safe-outputs level.Changes
Added validation test (
safe_output_types_validation.test.cjs): 8 test cases ensuringgithub-tokennever appears in safe output item types (safe-outputs.d.ts) while remaining in configuration types (safe-outputs-config.d.ts)Fixed integration tests: Removed
github-tokenfrom individual safe-output type configurations inindividual_github_token_integration_test.goandgithub_token_precedence_integration_test.goArchitecture
Correct placement:
Incorrect placement (removed from tests):
This ensures authentication tokens remain at the configuration layer, not the data layer.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login tags/v5 9567962/b392/_testmain.go /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.0.linux-amd64/pkg/tool/linux_amd64/link -s -w -buildmode=exe /home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.0.linconfig -o k/gh-aw/gh-aw/.github/workflows -importcfg /usr/bin/git -s -w -buildmode=exe git(http block)/usr/bin/gh gh api user --jq .login 5 l/linux_amd64/cgo /usr/bin/git l nk l/linux_amd64/liuser git rev-�� 4339-12710/test-purge-campaign-3130105315/.github/workflows l/linux_amd64/link 9567962/b419/workflow.test l -buildtags /usr/bin/go 9567962/b419/workflow.test(http block)/usr/bin/gh gh api user --jq .login 5f6f7fa3ce65cc88ee43edad937782e92841203e18bccf12a941a3e16bbaa28e 6549198/b313/importcfg 0/x64/bin/node 2e92841203e18bccf12a941a3e16bbaa28e/log.json -buildtags /home/REDACTED/go/xterm-color /usr/bin/gh 0/x6�� f27b0cd0c75271bc --secure-storage /usr/bin/git l -trimpath ux-amd64/pkg/too--root git(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.