Remove redundant safe-inputs env vars from MCP server config#8263
Merged
Remove redundant safe-inputs env vars from MCP server config#8263
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove GH_AW_GH_TOKEN from MCP server.config
Remove redundant safe-inputs env vars from MCP server config
Dec 31, 2025
pelikhan
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe-inputs environment variables (e.g.,
GH_AW_GH_TOKEN,GH_DEBUG) were being declared twice: once in the step'senvblock and again in the MCP server config'senvobject. Since safe-inputs uses HTTP transport, the agent process already has access to step-level environment variables.Changes
pkg/workflow/safe_inputs_renderer.go: ModifiedrenderSafeInputsMCPConfigWithOptionsto only include server configuration variables (GH_AW_SAFE_INPUTS_PORT,GH_AW_SAFE_INPUTS_API_KEY) in the MCP config'senvblockBefore/After
Before:
After:
Tool-specific environment variables remain in the step's
envblock where they're accessible to the agent process.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login -json GO111MODULE 0.1-go1.25.0.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 0.1-go1.25.0.linGOMODCACHE GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh api user --jq .login tags/v6 -buildtags /usr/bin/git -errorsas -ifaceassert 4547505563965291/tmp/validate-js-702397727.cjs git -c ithub/workflows log(http block)/usr/bin/gh gh api user --jq .login ithub/workflows go /usr/bin/git -json GO111MODULE 0.1-go1.25.0.lin--json git -C oad-artifact.git oad-artifact.git /usr/bin/gh l GO111MODULE 0.1-go1.25.0.linuser gh(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.