Skip to content

[security-fix] Fix path traversal vulnerability in schema compiler (Alert #457) #8803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 4, 2026
Merged

[security-fix] Fix path traversal vulnerability in schema compiler (Alert #457) #8803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkg/parser/schema_compiler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"errors"
"fmt"
"os"
"path/filepath"
"sort"
"strings"
"sync"
Expand Down Expand Up @@ -222,8 +223,11 @@ func validateWithSchemaAndLocation(frontmatter map[string]any, schemaJSON, conte
var frontmatterContent string
var frontmatterStart = 2 // Default: frontmatter starts at line 2

// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(filePath)

if filePath != "" {
if content, readErr := os.ReadFile(filePath); readErr == nil {
if content, readErr := os.ReadFile(cleanPath); readErr == nil {
lines := strings.Split(string(content), "\n")

// Look for frontmatter section with improved detection
Expand Down Expand Up @@ -267,7 +271,8 @@ func validateWithSchemaAndLocation(frontmatter map[string]any, schemaJSON, conte
// Create context lines around the adjusted line number in the full file
var adjustedContextLines []string
if filePath != "" {
if content, readErr := os.ReadFile(filePath); readErr == nil {
// Use the same sanitized path
if content, readErr := os.ReadFile(cleanPath); readErr == nil {
allLines := strings.Split(string(content), "\n")
// Create context around the adjusted line (±3 lines)
// The console formatter expects context to be centered around the error line
Expand Down