Skip to content

Security Fix: Correct directory permissions in logs_download.go (Alerts #461, #460) #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 4, 2026
Merged

Security Fix: Correct directory permissions in logs_download.go (Alerts #461, #460) #8855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/cli/logs_download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,15 +149,15 @@ func flattenUnifiedArtifact(outputDir string, verbose bool) error {
destPath := filepath.Join(outputDir, relPath)

if info.IsDir() {
// Create directory in destination
if err := os.MkdirAll(destPath, 0755); err != nil {
// Create directory in destination with owner+group permissions only (0750)
if err := os.MkdirAll(destPath, 0750); err != nil {
return fmt.Errorf("failed to create directory %s: %w", destPath, err)
}
logsDownloadLog.Printf("Created directory: %s", destPath)
} else {
// Move file to destination
// Ensure parent directory exists
if err := os.MkdirAll(filepath.Dir(destPath), 0755); err != nil {
// Ensure parent directory exists with owner+group permissions only (0750)
if err := os.MkdirAll(filepath.Dir(destPath), 0750); err != nil {
return fmt.Errorf("failed to create parent directory for %s: %w", destPath, err)
}

Expand Down