Fix add_labels.test.cjs test framework and empty labels behavior#9006
Merged
pelikhan merged 3 commits intojsweep-clean-add-labels-1c0bc3cff1aee696from Jan 5, 2026
Merged
Conversation
…tation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…essions) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Clean add_labels.cjs for conciseness and maintainability
Fix add_labels.test.cjs test framework and empty labels behavior
Jan 5, 2026
pelikhan
added a commit
that referenced
this pull request
Jan 5, 2026
* jsweep: Clean add_labels.cjs - Simplified item number determination with ternary expression - Consolidated error handling for invalid/missing item numbers - Removed unnecessary intermediate variables - Used spread operator for context.repo - Used shorthand property for contextType - Created comprehensive test file with 13 test cases - Reduced from 146 to 133 lines (13 lines saved) * Fix add_labels.test.cjs test framework and empty labels behavior (#9006) * Initial plan * Fix add_labels.test.cjs to use vitest and fix empty labels test expectation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Apply prettier formatting to add_labels.cjs (single-line ternary expressions) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> * Add changeset [skip-ci] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
add_labels.test.cjsfile was using Node.js native test runner instead of vitest, causing test suite discovery failures. Additionally, the empty labels test expected error behavior when the code actually handles it gracefully as success.Changes
Test framework migration - Converted from
node:testto vitestrequire("node:test")→import { describe, it, expect, beforeEach } from "vitest"assert.strictEqual()→expect().toBe(),assert.deepStrictEqual()→expect().toEqual()Empty labels test fix - Updated expectation to match actual code behavior
Code formatting - Applied Prettier to
add_labels.cjs(single-line ternary expressions)All 15 tests now pass with proper vitest integration.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.