Skip to content

[security-fix] Fix file permissions in git.go (Alerts #373, #372) #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 5, 2026
Merged

[security-fix] Fix file permissions in git.go (Alerts #373, #372) #9014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/cli/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ func ensureGitAttributes() error {
return nil
}

// Write back to file
// Write back to file with owner-only read/write permissions (0600) for security best practices
content := strings.Join(lines, "\n")
if err := os.WriteFile(gitAttributesPath, []byte(content), 0644); err != nil {
if err := os.WriteFile(gitAttributesPath, []byte(content), 0600); err != nil {
gitLog.Printf("Failed to write .gitattributes: %v", err)
return fmt.Errorf("failed to write .gitattributes: %w", err)
}
Expand Down Expand Up @@ -261,14 +261,14 @@ func ensureLogsGitignore() error {
return fmt.Errorf("failed to create .github/aw/logs directory: %w", err)
}

// Write the .gitignore file
// Write the .gitignore file with owner-only read/write permissions (0600) for security best practices
gitignoreContent := `# Ignore all downloaded workflow logs
*

# But keep the .gitignore file itself
!.gitignore
`
if err := os.WriteFile(gitignorePath, []byte(gitignoreContent), 0644); err != nil {
if err := os.WriteFile(gitignorePath, []byte(gitignoreContent), 0600); err != nil {
gitLog.Printf("Failed to write .gitignore: %v", err)
return fmt.Errorf("failed to write .github/aw/logs/.gitignore: %w", err)
}
Expand Down