Skip to content

Security Fix: Path traversal vulnerabilities in logs_metrics.go (Alerts #476, #475) #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 7, 2026
Merged

Security Fix: Path traversal vulnerabilities in logs_metrics.go (Alerts #476, #475) #9180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions pkg/cli/logs_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,14 @@ func extractMissingToolsFromRun(runDir string, run WorkflowRun, verbose bool) ([
}

if resolvedAgentOutputFile != "" {
// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(resolvedAgentOutputFile)

// Read the safe output artifact file
content, readErr := os.ReadFile(resolvedAgentOutputFile)
content, readErr := os.ReadFile(cleanPath)
if readErr != nil {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to read safe output file %s: %v", resolvedAgentOutputFile, readErr)))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to read safe output file %s: %v", cleanPath, readErr)))
}
return missingTools, nil // Continue processing without this file
}
Expand All @@ -263,7 +266,7 @@ func extractMissingToolsFromRun(runDir string, run WorkflowRun, verbose bool) ([

if err := json.Unmarshal(content, &safeOutput); err != nil {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to parse safe output JSON from %s: %v", resolvedAgentOutputFile, err)))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to parse safe output JSON from %s: %v", cleanPath, err)))
}
return missingTools, nil // Continue processing without this file
}
Expand Down Expand Up @@ -369,11 +372,14 @@ func extractNoopsFromRun(runDir string, run WorkflowRun, verbose bool) ([]NoopRe
}

if resolvedAgentOutputFile != "" {
// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(resolvedAgentOutputFile)

// Read the safe output artifact file
content, readErr := os.ReadFile(resolvedAgentOutputFile)
content, readErr := os.ReadFile(cleanPath)
if readErr != nil {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to read safe output file %s: %v", resolvedAgentOutputFile, readErr)))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to read safe output file %s: %v", cleanPath, readErr)))
}
return noops, nil // Continue processing without this file
}
Expand All @@ -386,7 +392,7 @@ func extractNoopsFromRun(runDir string, run WorkflowRun, verbose bool) ([]NoopRe

if err := json.Unmarshal(content, &safeOutput); err != nil {
if verbose {
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to parse safe output JSON from %s: %v", resolvedAgentOutputFile, err)))
fmt.Fprintln(os.Stderr, console.FormatWarningMessage(fmt.Sprintf("Failed to parse safe output JSON from %s: %v", cleanPath, err)))
}
return noops, nil // Continue processing without this file
}
Expand Down