Fix campaign validation to use spec directory instead of global workflow directory#9267
Merged
Fix campaign validation to use spec directory instead of global workflow directory#9267
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Campaign validation now uses each campaign spec's directory to find referenced workflows, rather than using a global workflow directory parameter. This fixes the issue where campaigns failed validation when compiled individually from the command line. Changes: - Modified validateCampaigns() in pkg/cli/compile_campaign.go to use filepath.Dir(spec.ConfigPath) instead of absWorkflowDir - Added test to verify campaigns validate with correct directory - All campaign compilation tests pass Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation of campaigns in current build
Fix campaign validation to use spec directory instead of global workflow directory
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaign spec validation was failing because
validateCampaigns()used a globalworkflowDirparameter to locate referenced workflows, rather than using each campaign spec's own directory.Changes
pkg/cli/compile_campaign.go: ModifiedvalidateCampaigns()to derive workflow directory from each spec'sConfigPathinstead of using the global parameterpkg/cli/compile_campaign_validation_test.go: Added test verifying campaigns validate using their own directoryExample
Before:
After:
This fixes compilation of both existing campaign files:
docs-quality-maintenance-project67.campaign.mdfile-size-reduction-project71.campaign.mdWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/user/usr/bin/gh gh api user --jq .login workflows gh /usr/bin/git /ref/tags/v8 --jq 0/x64/bin/node git -C ithub/workflows config /usr/bin/git by/5ec84845b6c75gh infocmp /usr/bin/infocmpdownload git(http block)/usr/bin/gh gh api user --jq .login /ref/tags/v8 gh by/5ec84845b6c75cc625d7ed6e0f1469b68a45df01371bce84d38a421cdfdb030a/log.json /repos/actions/ginfocmp --jq /usr/bin/gh gh auth�� purge-campaign-lock-3346377628/.github/workflows gh by/5ec84845b6c75cc625d7ed6e0f1469b68a45df01371bce84d38a421cdfdb030a/init.pid d38a421cdfdb030ainfocmp --jq /usr/bin/gh git(http block)/usr/bin/gh gh api user --jq .login b/workflows rev-parse f4b8f2a4f7de7872e6a526e341004efccf2/log.json xterm-color e/git-remote-httrun /usr/bin/infocmpdownload infocmp -1 k/gh-aw/gh-aw/.g/tmp/gh-aw-test-runs/20260107-192640-41436/test-orchestrator-1704465491/run-1234/usr/bin/networkctl infocmp /usr/bin/git 1624471/run-3 infocmp(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.